unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* `fset' in insert-file-contents-literally
@ 2010-03-22 16:04 Stefan Monnier
  2010-03-22 18:16 ` Eli Zaretskii
  0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2010-03-22 16:04 UTC (permalink / raw)
  To: emacs-devel

Could someone try to get rid of the:

  (fset 'find-buffer-file-type (lambda (filename) t))

in insert-file-contents-literally, e.g. by changing
find-buffer-file-type such that it always returns t when
coding-system-for-read and coding-system-for-write and set to something
like `no-conversion'?


        Stefan




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: `fset' in insert-file-contents-literally
  2010-03-22 16:04 `fset' in insert-file-contents-literally Stefan Monnier
@ 2010-03-22 18:16 ` Eli Zaretskii
  2010-03-22 18:38   ` Stefan Monnier
  0 siblings, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2010-03-22 18:16 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Mon, 22 Mar 2010 12:04:04 -0400
> 
> Could someone try to get rid of the:
> 
>   (fset 'find-buffer-file-type (lambda (filename) t))
> 
> in insert-file-contents-literally, e.g. by changing
> find-buffer-file-type such that it always returns t when
> coding-system-for-read and coding-system-for-write and set to something
> like `no-conversion'?

I think we should get rid of find-buffer-file-type itself and its
companion file-name-buffer-file-type-alist.  They've become redundant
long ago, since EOL decoding was introduced.  It's time to say
good-bye.  We should use the equivalent Mule facilities for that.




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: `fset' in insert-file-contents-literally
  2010-03-22 18:16 ` Eli Zaretskii
@ 2010-03-22 18:38   ` Stefan Monnier
  2010-03-22 19:13     ` Eli Zaretskii
  0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2010-03-22 18:38 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel

> I think we should get rid of find-buffer-file-type itself and its
> companion file-name-buffer-file-type-alist.  They've become redundant
> long ago, since EOL decoding was introduced.  It's time to say
> good-bye.  We should use the equivalent Mule facilities for that.

I'm all for it, yes,


        Stefan "Who just doesn't know enough about w32 to suggest such changes"




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: `fset' in insert-file-contents-literally
  2010-03-22 18:38   ` Stefan Monnier
@ 2010-03-22 19:13     ` Eli Zaretskii
  0 siblings, 0 replies; 4+ messages in thread
From: Eli Zaretskii @ 2010-03-22 19:13 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: emacs-devel@gnu.org
> Date: Mon, 22 Mar 2010 14:38:40 -0400
> 
> > I think we should get rid of find-buffer-file-type itself and its
> > companion file-name-buffer-file-type-alist.  They've become redundant
> > long ago, since EOL decoding was introduced.  It's time to say
> > good-bye.  We should use the equivalent Mule facilities for that.
> 
> I'm all for it, yes,
> 
> 
>         Stefan "Who just doesn't know enough about w32 to suggest such changes"

All file-name-buffer-file-type-alist does is force certain files
(those that have t in the cdr of their association) be read with
no-conversion.  That's it.




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2010-03-22 19:13 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-22 16:04 `fset' in insert-file-contents-literally Stefan Monnier
2010-03-22 18:16 ` Eli Zaretskii
2010-03-22 18:38   ` Stefan Monnier
2010-03-22 19:13     ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).