From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Base patch for bug #5975 (bookmarking from Gnus Article buffer). Date: Wed, 14 Jul 2010 11:37:32 +0300 Message-ID: <83oceaqx0z.fsf@gnu.org> References: <87y6dydn6q.fsf@tux.homenetwork> <201006292126.15409.tassilo@member.fsf.org> <87iq51ehnv.fsf@tux.homenetwork> <201006292210.43121.tassilo@member.fsf.org> <87eifpegqx.fsf@tux.homenetwork> <87k4ozdq6b.fsf_-_@red-bean.com> <87d3urdppj.fsf@red-bean.com> <87sk3mbh60.fsf@tux.homenetwork> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1279096825 4304 80.91.229.12 (14 Jul 2010 08:40:25 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 14 Jul 2010 08:40:25 +0000 (UTC) Cc: emacs-devel@gnu.org To: Thierry Volpiatto Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 14 10:40:22 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OYxVs-0002uG-IJ for ged-emacs-devel@m.gmane.org; Wed, 14 Jul 2010 10:40:22 +0200 Original-Received: from localhost ([127.0.0.1]:55634 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OYxVo-0007n2-6e for ged-emacs-devel@m.gmane.org; Wed, 14 Jul 2010 04:40:16 -0400 Original-Received: from [140.186.70.92] (port=60443 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OYxVd-0007iW-IC for emacs-devel@gnu.org; Wed, 14 Jul 2010 04:40:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OYxV7-0000Ea-Uj for emacs-devel@gnu.org; Wed, 14 Jul 2010 04:39:34 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:48152) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OYxV7-0000EL-NA for emacs-devel@gnu.org; Wed, 14 Jul 2010 04:39:33 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0L5J00000GS8HK00@a-mtaout20.012.net.il> for emacs-devel@gnu.org; Wed, 14 Jul 2010 11:39:31 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([77.127.120.144]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L5J00EL0HDU03I0@a-mtaout20.012.net.il>; Wed, 14 Jul 2010 11:39:31 +0300 (IDT) In-reply-to: <87sk3mbh60.fsf@tux.homenetwork> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:127263 Archived-At: > From: Thierry Volpiatto > Date: Wed, 14 Jul 2010 10:29:11 +0200 > > if patch WORK and is basically correct and is accepted of course, why > not applying patch as it is and modifying as Emacs developpers like in > one or more little other commits. Because there's a pedagogical value for the contributors in having them fix their code according to review comments. In general, you learn better what you do yourself, rather than watching others do it for you.