From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r101633: Add fd handling with callbacks to select, dbus needs it for async operation. Date: Sun, 26 Sep 2010 21:17:46 +0200 Message-ID: <83ocbkqpph.fsf@gnu.org> References: <83sk0wqs06.fsf@gnu.org> <4C9F99F4.70803@swipnet.se> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE X-Trace: dough.gmane.org 1285528674 3361 80.91.229.12 (26 Sep 2010 19:17:54 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 26 Sep 2010 19:17:54 +0000 (UTC) Cc: emacs-devel@gnu.org To: =?ISO-8859-1?Q?Jan_Dj=E4rv?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 26 21:17:53 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OzwjP-0001fT-MR for ged-emacs-devel@m.gmane.org; Sun, 26 Sep 2010 21:17:51 +0200 Original-Received: from localhost ([127.0.0.1]:53585 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OzwjP-0006lQ-19 for ged-emacs-devel@m.gmane.org; Sun, 26 Sep 2010 15:17:51 -0400 Original-Received: from [140.186.70.92] (port=40754 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OzwjH-0006jW-KN for emacs-devel@gnu.org; Sun, 26 Sep 2010 15:17:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OzwjF-0005N5-H6 for emacs-devel@gnu.org; Sun, 26 Sep 2010 15:17:43 -0400 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:34077) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OzwjF-0005Mm-66 for emacs-devel@gnu.org; Sun, 26 Sep 2010 15:17:41 -0400 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0L9D00G00C2RPC00@a-mtaout23.012.net.il> for emacs-devel@gnu.org; Sun, 26 Sep 2010 21:17:39 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.229.212.132]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L9D00GP7C9EO820@a-mtaout23.012.net.il>; Sun, 26 Sep 2010 21:17:39 +0200 (IST) In-reply-to: <4C9F99F4.70803@swipnet.se> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:130933 Archived-At: > Date: Sun, 26 Sep 2010 21:07:32 +0200 > From: Jan Dj=E4rv > CC: emacs-devel@gnu.org >=20 > > The changes that remove the "#ifdef subprocesses" conditionals wi= ll > > probably break the MSDOS build, because input_wait_mask etc. are = only > > defined "#ifdef subprocesses". The functions > > add_keyboard_wait_descriptor and delete_keyboard_wait_descriptor = are > > supposed to be no-ops for the MSDOS build. >=20 > We need another ifdef then as dbus and for example session file des= criptors=20 > have nothing to do with subprocesses. #ifndef MSDOS perhaps? The only Emacs build that doesn't have `subprocesses' #define'd is th= e MSDOS build. Using "#ifdef subprocesses" is just slightly less ugly then OS-dependent #define, but otherwise it is functionally identical to "#ifndef MSDOS". So I don't think we need another ifdef.