From: Eli Zaretskii <eliz@gnu.org>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: eggert@cs.ucla.edu, emacs-devel@gnu.org, jasonr@gnu.org
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109864: Fix minor problems found by static checking.
Date: Tue, 04 Sep 2012 19:52:05 +0300 [thread overview]
Message-ID: <83obllennu.fsf@gnu.org> (raw)
In-Reply-To: <m2r4qhn9gt.fsf@igel.home>
> From: Andreas Schwab <schwab@linux-m68k.org>
> Cc: Eli Zaretskii <eliz@gnu.org>, Paul Eggert <eggert@cs.ucla.edu>, emacs-devel@gnu.org
> Date: Tue, 04 Sep 2012 16:33:54 +0200
>
> Jason Rumney <jasonr@gnu.org> writes:
>
> > It's not valid C89 is it?
>
> Sure it is. Declarations with initializer are allowed anywhere at the
> start of the block.
Yes. But the fragment I cited didn't show the block beginning, which
is probably why Jason thought it's not valid C89. Here's more
context (from another hunk of the same commit):
--- a/src/xdisp.c 2012-09-02 17:10:35 +0000
+++ b/src/xdisp.c 2012-09-03 09:22:43 +0000
@@ -13511,9 +13511,10 @@
}
else if (FRAME_VISIBLE_P (sf) && !FRAME_OBSCURED_P (sf))
{
- Lisp_Object mini_window = FRAME_MINIBUF_WINDOW (sf);
+ Lisp_Object mini_window;
struct frame *mini_frame;
+ mini_window = FRAME_MINIBUF_WINDOW (sf);
displayed_buffer = XBUFFER (XWINDOW (selected_window)->buffer);
/* Use list_of_error, not Qerror, so that
we catch only errors and don't run the debugger. */
next prev parent reply other threads:[~2012-09-04 16:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.503691.1346667442.854.emacs-diffs@gnu.org>
2012-09-03 15:35 ` [Emacs-diffs] /srv/bzr/emacs/trunk r109864: Fix minor problems found by static checking Eli Zaretskii
2012-09-03 18:54 ` Stefan Monnier
2012-09-03 19:37 ` Paul Eggert
2012-09-03 20:44 ` Eli Zaretskii
2012-09-03 22:29 ` Paul Eggert
2012-09-04 3:41 ` Stefan Monnier
2012-09-04 5:29 ` Jan Djärv
2012-09-04 5:45 ` Paul Eggert
2012-09-04 8:31 ` Jan Djärv
2012-09-04 8:58 ` Paul Eggert
2012-09-04 10:25 ` Jan Djärv
2012-09-04 14:29 ` Jason Rumney
2012-09-04 19:19 ` Stefan Monnier
2012-09-04 18:51 ` Wojciech Meyer
2012-09-04 18:22 ` Wojciech Meyer
2012-09-04 14:26 ` Jason Rumney
2012-09-04 14:33 ` Andreas Schwab
2012-09-04 16:52 ` Eli Zaretskii [this message]
2012-09-04 18:36 ` Wojciech Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83obllennu.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=jasonr@gnu.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).