From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Windows: Emacs 24.1 binary size vs 24.2 binary size Date: Mon, 10 Sep 2012 07:52:42 +0300 Message-ID: <83oblelbs5.fsf@gnu.org> References: <503D7C5B.4080701@gmail.com> <504219DA.20309@gmail.com> <83pq65g5lx.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1347252780 20123 80.91.229.3 (10 Sep 2012 04:53:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 10 Sep 2012 04:53:00 +0000 (UTC) Cc: emacs-devel@gnu.org To: Christoph Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Sep 10 06:53:02 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TAvzX-0003KI-IR for ged-emacs-devel@m.gmane.org; Mon, 10 Sep 2012 06:52:59 +0200 Original-Received: from localhost ([::1]:36268 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TAvzU-0001dY-5T for ged-emacs-devel@m.gmane.org; Mon, 10 Sep 2012 00:52:56 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:54215) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TAvzR-0001dM-EL for emacs-devel@gnu.org; Mon, 10 Sep 2012 00:52:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TAvzQ-0004ry-8x for emacs-devel@gnu.org; Mon, 10 Sep 2012 00:52:53 -0400 Original-Received: from mtaout21.012.net.il ([80.179.55.169]:50937) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TAvzQ-0004rs-0t for emacs-devel@gnu.org; Mon, 10 Sep 2012 00:52:52 -0400 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MA400K00ATQHX00@a-mtaout21.012.net.il> for emacs-devel@gnu.org; Mon, 10 Sep 2012 07:52:37 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MA400KT1AVOHQ00@a-mtaout21.012.net.il>; Mon, 10 Sep 2012 07:52:37 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:153209 Archived-At: > Date: Sun, 9 Sep 2012 20:42:06 -0600 > From: Christoph > Cc: emacs-devel@gnu.org > > Bisection via bootstraps lead to r108079 where the size decreases to 9,634 > KB. > > > Backport fix for Bug#11989 from trunk. > > * mouse.el (mouse-drag-track): Do not set the mark if the user > releases the mouse without selecting anything. > > > Bootstrapping r108078 yields emacs.exe with 11,062KB, bootstrapping r108079 > yields 9,634KB. I did it multiple times to be sure. > > Any ideas? None whatsoever. This revision changes a few lines in a single function, see the diffs below. None of the changes should cause or prevent loading of some other package, AFAICS. IOW, it all sounds like some obscure bug triggered indirectly either by previous versions or by the new version. Beats me how, though. One way to explore this further would be to dump the pure space in the 2 builds and compare them. I don't know of any convenient method of doing that. In any case, I don't think you should delay the 24.2 binaries any more. I'm using 24.2 every day since the release, on 2 different machines, and didn't see any problems. Thanks. === modified file 'lisp/mouse.el' --- lisp/mouse.el 2012-04-20 08:49:24 +0000 +++ lisp/mouse.el 2012-07-25 06:14:30 +0000 @@ -806,7 +806,7 @@ DO-MOUSE-DRAG-REGION-POST-PROCESS should ;; when setting point near the right fringe (but see below). (automatic-hscrolling-saved automatic-hscrolling) (automatic-hscrolling nil) - event end end-point) + moved-off-start event end end-point) (setq mouse-selection-click-count click-count) ;; In case the down click is in the middle of some intangible text, @@ -841,6 +841,9 @@ DO-MOUSE-DRAG-REGION-POST-PROCESS should (redisplay)) (setq end (event-end event) end-point (posn-point end)) + ;; Note whether the mouse has left the starting position. + (unless (eq end-point start-point) + (setq moved-off-start t)) (if (and (eq (posn-window end) start-window) (integer-or-marker-p end-point)) (mouse--drag-set-mark-and-point start-point @@ -881,11 +884,11 @@ DO-MOUSE-DRAG-REGION-POST-PROCESS should (let (deactivate-mark) (copy-region-as-kill (mark) (point))))) - ;; If point hasn't moved, run the binding of the - ;; terminating up-event. - (if do-multi-click - (goto-char start-point) - (deactivate-mark)) + ;; Otherwise, run binding of terminating up-event. + (cond + (do-multi-click (goto-char start-point)) + (moved-off-start (deactivate-mark)) + (t (pop-mark))) (when (and (functionp fun) (= start-hscroll (window-hscroll start-window)) ;; Don't run the up-event handler if the window