From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Long lines and bidi Date: Sat, 09 Feb 2013 11:33:21 +0200 Message-ID: <83obft7rxa.fsf@gnu.org> References: <877gmp5a04.fsf@ed.ac.uk> <83vca89izh.fsf@gnu.org> <5110906D.7020406@yandex.ru> <83fw1aac3d.fsf@gnu.org> <51120360.4060104@yandex.ru> <51127363.5030203@yandex.ru> <834nhp9u9j.fsf@gnu.org> <5114FEBB.8020201@yandex.ru> <838v6y99wk.fsf@gnu.org> <836222983u.fsf@gnu.org> <51152A00.6070101@yandex.ru> <83y5ey7npl.fsf@gnu.org> <5115C3BC.8020203@cs.ucla.edu> <83txpl7u3w.fsf@gnu.org> <5116113D.5070707@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1360402409 4379 80.91.229.3 (9 Feb 2013 09:33:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 9 Feb 2013 09:33:29 +0000 (UTC) Cc: dmantipov@yandex.ru, emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Feb 09 10:33:50 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U46od-0003bN-Of for ged-emacs-devel@m.gmane.org; Sat, 09 Feb 2013 10:33:47 +0100 Original-Received: from localhost ([::1]:44547 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U46oK-0006T4-Mj for ged-emacs-devel@m.gmane.org; Sat, 09 Feb 2013 04:33:28 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:54539) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U46oH-0006Sx-6f for emacs-devel@gnu.org; Sat, 09 Feb 2013 04:33:26 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U46oE-0001I3-Li for emacs-devel@gnu.org; Sat, 09 Feb 2013 04:33:25 -0500 Original-Received: from mtaout21.012.net.il ([80.179.55.169]:49348) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U46oE-0001He-EF for emacs-devel@gnu.org; Sat, 09 Feb 2013 04:33:22 -0500 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MHY00I0056G0Y00@a-mtaout21.012.net.il> for emacs-devel@gnu.org; Sat, 09 Feb 2013 11:33:20 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MHY00I9F57J0910@a-mtaout21.012.net.il>; Sat, 09 Feb 2013 11:33:20 +0200 (IST) In-reply-to: <5116113D.5070707@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:156916 Archived-At: > Date: Sat, 09 Feb 2013 01:05:01 -0800 > From: Paul Eggert > Cc: dmantipov@yandex.ru, emacs-devel@gnu.org > > > At the very least, the name of the function should be > > changed to reflect the change. > > Sure, what name do you suggest? scan_newline is already taken. > Perhaps scan_buffer_newline? I'd use find_newline, since 2 out of 3 of its callers are find_next_newline_no_quit and find_before_next_newline. > This area is a bit messed up, unfortunately -- scan_newline has > comments saying that it looks for carriage return (!) but > it does not in fact do that. People tend to forget updating the commentary when they change code.