From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Checking in files with trailing white space Date: Tue, 13 Dec 2016 18:01:57 +0200 Message-ID: <83oa0fbyx6.fsf@gnu.org> References: <20161211133110.GB14084@acm.fritz.box> <20161212221642.GA4361@acm.fritz.box> <83wpf4bj26.fsf@gnu.org> <366009d8-72f4-2f85-103c-214a5e111e77@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1481644950 19014 195.159.176.226 (13 Dec 2016 16:02:30 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 13 Dec 2016 16:02:30 +0000 (UTC) Cc: acm@muc.de, larsi@gnus.org, emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 13 17:02:19 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cGpWx-0003Ma-Pe for ged-emacs-devel@m.gmane.org; Tue, 13 Dec 2016 17:02:15 +0100 Original-Received: from localhost ([::1]:39164 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cGpX1-00064x-Vk for ged-emacs-devel@m.gmane.org; Tue, 13 Dec 2016 11:02:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54207) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cGpWq-00062J-83 for emacs-devel@gnu.org; Tue, 13 Dec 2016 11:02:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cGpWl-0003z7-SH for emacs-devel@gnu.org; Tue, 13 Dec 2016 11:02:08 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46695) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cGpWl-0003z3-PH; Tue, 13 Dec 2016 11:02:03 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2212 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cGpWl-0008GH-0I; Tue, 13 Dec 2016 11:02:03 -0500 In-reply-to: <366009d8-72f4-2f85-103c-214a5e111e77@cs.ucla.edu> (message from Paul Eggert on Mon, 12 Dec 2016 23:31:42 -0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210404 Archived-At: > Cc: acm@muc.de, larsi@gnus.org, emacs-devel@gnu.org > From: Paul Eggert > Date: Mon, 12 Dec 2016 23:31:42 -0800 > > An example of trouble is test/manual/etags/f-src/entry.strange.gz. Instead of > committing the gzipped file, I'd commit the original text file 'entry.strange', > and compress a copy as part of the test. But what about data files that cannot be easily produced from text on any garden-variety system? > To see an example problem when binary data is committed, visit this URL: > > http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=6db72771cc08e719a08f56db8abd7cefef9c8c99 > > Because that commit installed some Latin-1 text, the body of that web page > contains a mixture of UTF-8 and Latin-1. Sometimes this is necessary. We could, of course, recode the file using Emacs, but only in most cases, not all of them. E.g., producing a file with invalid bytes might not be easy at all. And for other use cases, doing what you want might be next to impossible, except if we write a C or Lisp program to generate the data, something that might make the job significantly harder than just grabbing a file. So I think it would be good to avoid binary data when feasible, but I won't make that a hard requirement. We don't want to make the job of adding tests any harder than it already is.