From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 0a5b6e2: Fix aborts in GC under GC_CHECK_MARKED_OBJECTS Date: Wed, 21 Dec 2016 22:40:56 +0200 Message-ID: <83oa0510dj.fsf@gnu.org> References: <20161221201813.3130.28327@vcs.savannah.gnu.org> <20161221201813.A13CA2201BA@vcs.savannah.gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1482352937 26404 195.159.176.226 (21 Dec 2016 20:42:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 21 Dec 2016 20:42:17 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 21 21:42:11 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cJni9-0005No-To for ged-emacs-devel@m.gmane.org; Wed, 21 Dec 2016 21:42:06 +0100 Original-Received: from localhost ([::1]:58917 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cJniE-0000LX-4R for ged-emacs-devel@m.gmane.org; Wed, 21 Dec 2016 15:42:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59099) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cJnhf-0000Kv-4F for emacs-devel@gnu.org; Wed, 21 Dec 2016 15:41:36 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cJnhc-0003T2-2U for emacs-devel@gnu.org; Wed, 21 Dec 2016 15:41:35 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54128) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cJnhb-0003Sy-V8; Wed, 21 Dec 2016 15:41:31 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4683 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cJnhZ-0008FA-M3; Wed, 21 Dec 2016 15:41:30 -0500 In-reply-to: (message from Stefan Monnier on Wed, 21 Dec 2016 15:29:12 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210716 Archived-At: > From: Stefan Monnier > Cc: Eli Zaretskii > Date: Wed, 21 Dec 2016 15:29:12 -0500 > > > for thread objects. They are marked via the all_threads list, and > > therefore don't need to be inserted into the red-black tree, so > > mem_find will never find them. > > Hmm... when are they removed from all_threads? When the thread exits, see run_thread. > If they're removed from all_threads when the thread terminates, then > there can still be references to the thread object stored elsewhere in > the heap. They are all unlinked in run_thread, when the thread exits, AFAICT. Or maybe I don't understand what you mean by "references".