From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: bug#21072: Brave new mark-defun (and a testing tool) Date: Tue, 07 Mar 2017 18:46:03 +0200 Message-ID: <83o9xdghmc.fsf@gnu.org> References: <87o9ydrzkr.fsf@mbork.pl> <87mvdriuss.fsf@mbork.pl> <87bmu6icea.fsf@mbork.pl> <87wpctgieu.fsf@mbork.pl> <52e67f43-edcf-09e3-5fd6-6079763fd234@yandex.ru> <87tw7wh9sf.fsf@mbork.pl> <87k28sdka6.fsf@jane> <87efyze00g.fsf@jane> <87bmu2eoji.fsf@jane> <87wpcpw61w.fsf@jane> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1488905236 21481 195.159.176.226 (7 Mar 2017 16:47:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 7 Mar 2017 16:47:16 +0000 (UTC) Cc: emacs-devel@gnu.org, monnier@iro.umontreal.ca, 21072@debbugs.gnu.org To: Marcin Borkowski Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 07 17:47:10 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1clIGP-0004cQ-Ic for ged-emacs-devel@m.gmane.org; Tue, 07 Mar 2017 17:47:05 +0100 Original-Received: from localhost ([::1]:51630 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1clIGV-0007Uh-Gx for ged-emacs-devel@m.gmane.org; Tue, 07 Mar 2017 11:47:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39414) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1clIFv-0007U6-VR for emacs-devel@gnu.org; Tue, 07 Mar 2017 11:46:36 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1clIFs-0004kI-QK for emacs-devel@gnu.org; Tue, 07 Mar 2017 11:46:36 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39823) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1clIFs-0004k2-Mi; Tue, 07 Mar 2017 11:46:32 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4077 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1clIFr-0000CT-PF; Tue, 07 Mar 2017 11:46:32 -0500 In-reply-to: <87wpcpw61w.fsf@jane> (message from Marcin Borkowski on Fri, 17 Feb 2017 09:54:51 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:212816 Archived-At: > From: Marcin Borkowski > Date: Fri, 17 Feb 2017 09:54:51 +0100 > Cc: 21072@debbugs.gnu.org, emacs-devel@gnu.org > > OK, so I have renamed it and expanded the docstring. I attach > a corrected patch (the second one, the first one is the same as before). > > Is there anything else I can do before we may apply this patch and > consider bug#21072 fixed? Thanks, this looks good, but please move the tests to lisp-tests.el, to keep our conventions wrt test names. Then this could go in.