From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Suspicious warning in W64 build Date: Sat, 16 Sep 2017 09:40:37 +0300 Message-ID: <83o9qbkuxm.fsf@gnu.org> References: <1017454172.910810.1504618695244@mail.libero.it> <83tw0ezgi1.fsf@gnu.org> <1146932094.13821.1504798935795@mail.libero.it> <83mv66z66p.fsf@gnu.org> <102a4c21-c275-c73e-ec53-0d85975dc968@cs.ucla.edu> <83a825znuf.fsf@gnu.org> <831snhzkgw.fsf@gnu.org> <837ex9x7vf.fsf@gnu.org> <83tw0cwcle.fsf@gnu.org> <83h8wcw3td.fsf@gnu.org> <83377vx3d0.fsf@gnu.org> <83ingnq01t.fsf@gnu.org> <83fubrpxsv.fsf@gnu.org> <83r2v9masw.fsf@gnu.org> <83efr8mje5.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1505544094 20684 195.159.176.226 (16 Sep 2017 06:41:34 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 16 Sep 2017 06:41:34 +0000 (UTC) Cc: fabrice.popineau@centralesupelec.fr, emacs-devel@gnu.org To: Richard Copley Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 16 08:41:30 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dt6n9-00057w-Rt for ged-emacs-devel@m.gmane.org; Sat, 16 Sep 2017 08:41:27 +0200 Original-Received: from localhost ([::1]:56167 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dt6nF-00074k-NZ for ged-emacs-devel@m.gmane.org; Sat, 16 Sep 2017 02:41:33 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44766) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dt6mG-00073W-5k for emacs-devel@gnu.org; Sat, 16 Sep 2017 02:40:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dt6mD-0000Ww-Js for emacs-devel@gnu.org; Sat, 16 Sep 2017 02:40:32 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57815) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dt6mD-0000Wo-Fg; Sat, 16 Sep 2017 02:40:29 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4461 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dt6mC-0008RE-Sj; Sat, 16 Sep 2017 02:40:29 -0400 In-reply-to: (message from Richard Copley on Sat, 16 Sep 2017 00:05:44 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:218342 Archived-At: > From: Richard Copley > Date: Sat, 16 Sep 2017 00:05:44 +0100 > Cc: Fabrice Popineau , > Emacs Development > > On 15 September 2017 at 09:54, Eli Zaretskii wrote: > > About this warning: > > > > w32.c:7550:1: warning: no previous prototype for 'sys_strerror' [-Wmissing-prototypes] > > sys_strerror (int error_no) > > ^~~~~~~~~~~~ > > > > What MinGW64 header has the prototype of strerror? I thought it was > > string.h, like in mingw.org's headers, but evidently that's not true? > > If the prototype is in string.h, then why is this warning being > > displayed? > > It is in string.h. > Forgive me if I misunderstood, but isn't it because the warning is > about a prototype for sys_strerror, not a prototype for strerror? If you look at the beginning of w32.c, you will see that we include string.h before we #undef strerror. The header nt/inc/ms-w32.h #define's strerror to sys_strerror, so the inclusion of string.h should have supplied the prototype for sys_strerror. Why doesn't it do that in MinGW64? Does some system header #undef strerror too early?