From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master cc5325b: Pacify -Wcast-function-type warnings in GCC 8.1 Date: Mon, 20 Aug 2018 17:57:32 +0300 Message-ID: <83o9dxdr1f.fsf@gnu.org> References: <20180817143134.25638.77810@vcs0.savannah.gnu.org> <20180817143136.6E89A209C7@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1534776972 29317 195.159.176.226 (20 Aug 2018 14:56:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 20 Aug 2018 14:56:12 +0000 (UTC) Cc: andrewjmoreton@gmail.com, emacs-devel@gnu.org To: Ken Brown Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 20 16:56:07 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1frlbD-0007U7-56 for ged-emacs-devel@m.gmane.org; Mon, 20 Aug 2018 16:56:07 +0200 Original-Received: from localhost ([::1]:47588 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frldI-0001Ip-66 for ged-emacs-devel@m.gmane.org; Mon, 20 Aug 2018 10:58:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34786) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frlcj-0001Ii-AY for emacs-devel@gnu.org; Mon, 20 Aug 2018 10:57:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1frlci-0007CF-LW for emacs-devel@gnu.org; Mon, 20 Aug 2018 10:57:41 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35256) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frlcd-00079t-H1; Mon, 20 Aug 2018 10:57:35 -0400 Original-Received: from [176.228.60.248] (port=2782 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1frlcd-0001B6-4b; Mon, 20 Aug 2018 10:57:35 -0400 In-reply-to: (message from Ken Brown on Mon, 20 Aug 2018 09:29:03 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228727 Archived-At: > From: Ken Brown > Date: Mon, 20 Aug 2018 09:29:03 -0400 > > This breaks the Cygwin-w32 build because w32fns.c and w32uniscribe.c > don't include w32.h on Cygwin, so get_proc_addr is undefined. Sorry about that. > Could the definition of get_proc_addr be moved to a different header > that gets included in the Cygwin build? Maybe w32common.h? Moving to w32common.h is fine, but w32font.c doesn't include it. So something else is necessary.