From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Bignum speedup patch causes crash at startup Date: Wed, 05 Sep 2018 18:15:50 +0300 Message-ID: <83o9dcx9eh.fsf@gnu.org> References: <86h8j5f33t.fsf@gmail.com> <20300f3e-3061-2cf6-2431-bdd79d00820f@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1536160466 3903 195.159.176.226 (5 Sep 2018 15:14:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 5 Sep 2018 15:14:26 +0000 (UTC) Cc: andrewjmoreton@gmail.com, emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 05 17:14:22 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxZVd-0000k9-VG for ged-emacs-devel@m.gmane.org; Wed, 05 Sep 2018 17:14:22 +0200 Original-Received: from localhost ([::1]:56735 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxZXf-0005Zy-D2 for ged-emacs-devel@m.gmane.org; Wed, 05 Sep 2018 11:16:27 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53019) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxZXC-0005Om-2I for emacs-devel@gnu.org; Wed, 05 Sep 2018 11:15:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fxZX8-0002SN-TK for emacs-devel@gnu.org; Wed, 05 Sep 2018 11:15:57 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45559) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxZX8-0002SD-LJ; Wed, 05 Sep 2018 11:15:54 -0400 Original-Received: from [176.228.60.248] (port=1091 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fxZX8-0001PG-8K; Wed, 05 Sep 2018 11:15:54 -0400 In-reply-to: <20300f3e-3061-2cf6-2431-bdd79d00820f@cs.ucla.edu> (message from Paul Eggert on Tue, 4 Sep 2018 13:48:10 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:229294 Archived-At: > From: Paul Eggert > Date: Tue, 4 Sep 2018 13:48:10 -0700 > > > CC data.o > > In file included from C:/emacs/git/emacs/master/src/data.c:31: > > C:/emacs/git/emacs/master/src/data.c: In function 'arith_driver': > > C:/emacs/git/emacs/master/src/lisp.h:2479:34: warning: 'accum' may be used uninitialized in this function [-Wmaybe-uninitialized] > > return FIXNUM_OVERFLOW_P (n) ? make_bigint (n) : make_fixnum (n); > > ^~~~~~~~~~~~~~~ > > C:/emacs/git/emacs/master/src/data.c:2962:12: note: 'accum' was declared here > > intmax_t accum = XFIXNUM (val); > > GCC complains that 'accum' might be used uninitialized even though 'accum's > declaration has an initializer? Looks like a clear GCC bug, and might be worth > reporting there. Maybe it's because eassert can abort?