* Re: master 2d54710: lisp/vc/vc-git.el (vc-git-stash): Respect vc-dir marked files
[not found] ` <20180928145254.1C00620476@vcs0.savannah.gnu.org>
@ 2018-09-28 15:07 ` Robert Pluim
2018-09-28 16:08 ` Sam Steingold
0 siblings, 1 reply; 4+ messages in thread
From: Robert Pluim @ 2018-09-28 15:07 UTC (permalink / raw)
To: emacs-devel; +Cc: Sam Steingold
sds@gnu.org (Sam Steingold) writes:
> branch: master
> commit 2d54710c36c8b5f7e0d25eefd45c318c0cb533ea
> Author: Sam Steingold <sds@gnu.org>
> Commit: Sam Steingold <sds@gnu.org>
>
> lisp/vc/vc-git.el (vc-git-stash): Respect vc-dir marked files
So before 'stash' stashed all modified files, and now it only stashes
marked files? (what does it do if no files are marked?) If thatʼs an
accurate statement, this needs to be called out in NEWS.
Regards
Robert
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: master 2d54710: lisp/vc/vc-git.el (vc-git-stash): Respect vc-dir marked files
2018-09-28 15:07 ` master 2d54710: lisp/vc/vc-git.el (vc-git-stash): Respect vc-dir marked files Robert Pluim
@ 2018-09-28 16:08 ` Sam Steingold
2018-09-29 12:10 ` Robert Pluim
0 siblings, 1 reply; 4+ messages in thread
From: Sam Steingold @ 2018-09-28 16:08 UTC (permalink / raw)
To: Robert Pluim; +Cc: emacs-devel
If no files are marked, it stashes all modifications - like it did before.
I did not think such a minor change warrants a NEWS mention.
I will modify NEWS unless told otherwise soon.
(please keep me in CC, I have problems reading the list ATM).
Thanks.
On Fri, Sep 28, 2018 at 11:07 AM, Robert Pluim <rpluim@gmail.com> wrote:
> sds@gnu.org (Sam Steingold) writes:
>
>> branch: master
>> commit 2d54710c36c8b5f7e0d25eefd45c318c0cb533ea
>> Author: Sam Steingold <sds@gnu.org>
>> Commit: Sam Steingold <sds@gnu.org>
>>
>> lisp/vc/vc-git.el (vc-git-stash): Respect vc-dir marked files
>
> So before 'stash' stashed all modified files, and now it only stashes
> marked files? (what does it do if no files are marked?) If thatʼs an
> accurate statement, this needs to be called out in NEWS.
>
> Regards
>
> Robert
--
Sam Steingold <http://sds.podval.org> <http://www.childpsy.net>
<http://steingoldpsychology.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: master 2d54710: lisp/vc/vc-git.el (vc-git-stash): Respect vc-dir marked files
2018-09-28 16:08 ` Sam Steingold
@ 2018-09-29 12:10 ` Robert Pluim
2018-09-29 13:53 ` Eli Zaretskii
0 siblings, 1 reply; 4+ messages in thread
From: Robert Pluim @ 2018-09-29 12:10 UTC (permalink / raw)
To: Sam Steingold; +Cc: emacs-devel
Sam Steingold <sds@gnu.org> writes:
> If no files are marked, it stashes all modifications - like it did before.
> I did not think such a minor change warrants a NEWS mention.
> I will modify NEWS unless told otherwise soon.
A behaviour change is a behaviour change, however minor.
Regards
Robert
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: master 2d54710: lisp/vc/vc-git.el (vc-git-stash): Respect vc-dir marked files
2018-09-29 12:10 ` Robert Pluim
@ 2018-09-29 13:53 ` Eli Zaretskii
0 siblings, 0 replies; 4+ messages in thread
From: Eli Zaretskii @ 2018-09-29 13:53 UTC (permalink / raw)
To: Robert Pluim; +Cc: emacs-devel
> From: Robert Pluim <rpluim@gmail.com>
> Date: Sat, 29 Sep 2018 14:10:35 +0200
> Cc: emacs-devel@gnu.org
>
> Sam Steingold <sds@gnu.org> writes:
>
> > If no files are marked, it stashes all modifications - like it did before.
> > I did not think such a minor change warrants a NEWS mention.
> > I will modify NEWS unless told otherwise soon.
>
> A behaviour change is a behaviour change, however minor.
Indeed.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-29 13:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20180928145252.29055.9583@vcs0.savannah.gnu.org>
[not found] ` <20180928145254.1C00620476@vcs0.savannah.gnu.org>
2018-09-28 15:07 ` master 2d54710: lisp/vc/vc-git.el (vc-git-stash): Respect vc-dir marked files Robert Pluim
2018-09-28 16:08 ` Sam Steingold
2018-09-29 12:10 ` Robert Pluim
2018-09-29 13:53 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).