From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: No support for ImageMagick 7 in emacs-26 Date: Tue, 27 Nov 2018 07:48:27 +0200 Message-ID: <83o9abgjf8.fsf@gnu.org> References: <83efb9jf7x.fsf@gnu.org> <83zhtvhh8l.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1543297583 10668 195.159.176.226 (27 Nov 2018 05:46:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 27 Nov 2018 05:46:23 +0000 (UTC) Cc: emacs-devel@gnu.org To: Ulrich Mueller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 27 06:46:18 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gRWCQ-0002fF-MP for ged-emacs-devel@m.gmane.org; Tue, 27 Nov 2018 06:46:18 +0100 Original-Received: from localhost ([::1]:40121 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRWEX-0003Nx-5g for ged-emacs-devel@m.gmane.org; Tue, 27 Nov 2018 00:48:29 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54341) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRWER-0003No-2G for emacs-devel@gnu.org; Tue, 27 Nov 2018 00:48:23 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRWEN-0003WP-Ro for emacs-devel@gnu.org; Tue, 27 Nov 2018 00:48:22 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37072) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRWEN-0003WL-Os; Tue, 27 Nov 2018 00:48:19 -0500 Original-Received: from [176.228.60.248] (port=4117 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gRWEN-0001Zr-Cb; Tue, 27 Nov 2018 00:48:19 -0500 In-reply-to: (message from Ulrich Mueller on Mon, 26 Nov 2018 23:00:48 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231433 Archived-At: > From: Ulrich Mueller > Cc: emacs-devel@gnu.org > Date: Mon, 26 Nov 2018 23:00:48 +0100 > > We could put a conditional around it (but it looks silly): > > #ifdef HAVE_IMAGEMAGICK7 > double quantum_range = QuantumRange; > MagickRealType color_scale = 65535.0 / quantum_range; > #else > MagickRealType color_scale = 65535.0 / QuantumRange; > #fi > > > (why is it needed, anyway?). > > According to the commit message (commit 42ed35c68b): > > * src/image.c (imagemagick_load_image): Use double division, and > eliminate a cast. This avoids a -Wdouble-promotion warning with > GCC 7.3 on Ubuntu 18.04. So it's not really related to ImageMagick 7 support, right? > IMHO it would be shortsighted to support only a version that ImageMagick > upstream considers legacy. I may be shortsighted, but I'm not against adding v7 support, if it is done safely, as Emacs 26.2 is supposed to be more stable than 26.1, not less stable. Thanks.