unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Ulrich Mueller <ulm@gentoo.org>
Cc: emacs-devel@gnu.org
Subject: Re: No support for ImageMagick 7 in emacs-26
Date: Tue, 27 Nov 2018 07:48:27 +0200	[thread overview]
Message-ID: <83o9abgjf8.fsf@gnu.org> (raw)
In-Reply-To: <w6gy39fbisv.fsf@kph.uni-mainz.de> (message from Ulrich Mueller on Mon, 26 Nov 2018 23:00:48 +0100)

> From: Ulrich Mueller <ulm@gentoo.org>
> Cc: emacs-devel@gnu.org
> Date: Mon, 26 Nov 2018 23:00:48 +0100
> 
> We could put a conditional around it (but it looks silly):
> 
> #ifdef HAVE_IMAGEMAGICK7
>       double quantum_range = QuantumRange;
>       MagickRealType color_scale = 65535.0 / quantum_range;
> #else
>       MagickRealType color_scale = 65535.0 / QuantumRange;
> #fi
> 
> > (why is it needed, anyway?).
> 
> According to the commit message (commit 42ed35c68b):
>     
>     * src/image.c (imagemagick_load_image): Use double division, and
>     eliminate a cast.  This avoids a -Wdouble-promotion warning with
>     GCC 7.3 on Ubuntu 18.04.

So it's not really related to ImageMagick 7 support, right?

> IMHO it would be shortsighted to support only a version that ImageMagick
> upstream considers legacy.

I may be shortsighted, but I'm not against adding v7 support, if it is
done safely, as Emacs 26.2 is supposed to be more stable than 26.1,
not less stable.

Thanks.



  parent reply	other threads:[~2018-11-27  5:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-25  8:26 No support for ImageMagick 7 in emacs-26 Ulrich Mueller
2018-11-25 16:26 ` Eli Zaretskii
2018-11-26  7:38   ` Ulrich Mueller
2018-11-26 17:38     ` Eli Zaretskii
2018-11-26 22:00       ` Ulrich Mueller
2018-11-26 22:07         ` Andreas Schwab
2018-11-27  5:48         ` Eli Zaretskii [this message]
2018-11-27  1:38     ` Paul Eggert
2018-11-27  6:14       ` Eli Zaretskii
2018-11-27 16:35         ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83o9abgjf8.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=ulm@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).