From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: harfbuzz 2f72162: Fix crash in the Cairo build Date: Wed, 19 Dec 2018 17:06:45 +0200 Message-ID: <83o99hd08q.fsf@gnu.org> References: <20181214085417.15440.18845@vcs0.savannah.gnu.org> <20181214085418.6616820538@vcs0.savannah.gnu.org> <831s6kgrtj.fsf@gnu.org> <83pnu4f45d.fsf@gnu.org> <225c3958-7adf-ce9a-f7f5-c4531b8b6058@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1545231929 3383 195.159.176.226 (19 Dec 2018 15:05:29 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 19 Dec 2018 15:05:29 +0000 (UTC) Cc: emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 19 16:05:25 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZdPY-0000kk-Rb for ged-emacs-devel@m.gmane.org; Wed, 19 Dec 2018 16:05:24 +0100 Original-Received: from localhost ([::1]:60681 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZdRf-0001Zu-Ox for ged-emacs-devel@m.gmane.org; Wed, 19 Dec 2018 10:07:35 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50948) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZdQk-0001Xo-Vw for emacs-devel@gnu.org; Wed, 19 Dec 2018 10:06:40 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gZdQh-000597-2s for emacs-devel@gnu.org; Wed, 19 Dec 2018 10:06:38 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39079) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZdQg-000591-RS; Wed, 19 Dec 2018 10:06:34 -0500 Original-Received: from [176.228.60.248] (port=3751 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gZdQg-0005qp-DW; Wed, 19 Dec 2018 10:06:34 -0500 In-reply-to: (message from Robert Pluim on Wed, 19 Dec 2018 09:32:52 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231921 Archived-At: > From: Robert Pluim > Date: Wed, 19 Dec 2018 09:32:52 +0100 > > >> On 12/17/18 4:41 AM, Robert Pluim wrote: > >>> +#ifdef HAVE_XFT > >>> +#include > >>> +#include > >>> +#endif > >>> +#ifdef USE_CAIRO > >>> +#include > >>> +#endif > >> > >> Please indent the include directives by using "# include" (with a > >> space after "#"). > > > > Fixed. > > BTW, Emacs has ~500 instances of this rule not being followed. Iʼm > assuming that a mass change (similarly to mass whitespace fixes) would > be frowned upon. We usually fix those as part of other changes, not as a changeset in itself. Thanks.