unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Radon Rosborough <radon.neon@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Fix `early-init-file' value when file is missing
Date: Tue, 12 Feb 2019 18:14:14 +0200	[thread overview]
Message-ID: <83o97houg9.fsf@gnu.org> (raw)
In-Reply-To: <CADB4rJEa2vCgzakktT=OiJ10=TeTn2Tc-d0H4uvdCL6TLYVQ+w@mail.gmail.com> (message from Radon Rosborough on Mon, 11 Feb 2019 21:38:36 -0800)

> From: Radon Rosborough <radon.neon@gmail.com>
> Date: Mon, 11 Feb 2019 21:38:36 -0800
> Cc: emacs-devel <emacs-devel@gnu.org>
> 
> > I hope we can make a more direct test.
> 
> Okay, but as I mentioned in my previous message, I could amend this
> patch to not change the signature of `load-user-init-file' (even
> though the change has no logical impact whatsoever that could change
> user-facing behavior). Would you accept the patch if it didn't change
> the signature of `load-user-init-file'?

I think so, but it's hard to say without actually seeing the patch, or
at least hearing the idea which you intend to implement in a bit more
detail.

Let me just be clear: the most important aspect for me in this regard
is to be able to tell easily that the change affects only the
early-init file and cannot possibly affect the other caller, and also
that the change is obviously correct.  So if you can come up with such
a safe change, I will of course gladly accept it.

Thanks in advance, and sorry for causing you extra work.



  reply	other threads:[~2019-02-12 16:14 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-16  5:54 [PATCH] Fix `early-init-file' value when file is missing Radon Rosborough
2019-01-23  3:47 ` Radon Rosborough
2019-01-29 17:24   ` Radon Rosborough
2019-01-29 17:46     ` Eli Zaretskii
2019-02-01  9:11     ` Eli Zaretskii
2019-02-01 23:10       ` Radon Rosborough
2019-02-08  7:32         ` Eli Zaretskii
2019-02-08 17:34           ` Radon Rosborough
2019-02-08 21:52             ` Eli Zaretskii
2019-02-10 23:04               ` Radon Rosborough
2019-02-10 23:14                 ` Stefan Monnier
2019-02-11 16:05                 ` Eli Zaretskii
2019-02-12  5:38                   ` Radon Rosborough
2019-02-12 16:14                     ` Eli Zaretskii [this message]
2019-02-13  2:36                       ` Radon Rosborough
2019-02-13 17:56                         ` Eli Zaretskii
2019-02-16  0:47                           ` Radon Rosborough
2019-02-16  7:17                             ` Eli Zaretskii
2019-02-16 20:26                               ` Radon Rosborough

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83o97houg9.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=radon.neon@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).