From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Increase minimum required GTK versions? Date: Fri, 12 Apr 2019 22:14:50 +0300 Message-ID: <83o95bkpcl.fsf@gnu.org> References: <87h8b9tz84.fsf@gmail.com> <83h8b98wg3.fsf@gnu.org> <87d0lxty7f.fsf@gmail.com> <537036b7-549c-0aab-cc06-70c26c683ac7@cs.ucla.edu> <87y34kiloy.fsf@gmail.com> <87o95f141i.fsf@gmail.com> <838swj6nuk.fsf@gnu.org> <87h8b61rid.fsf@gmail.com> <83sgup6ef8.fsf@gnu.org> <87tvf5tm4f.fsf@gmail.com> <83r2a7kqi6.fsf@gnu.org> <8736mnvybp.fsf@gmail.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="238884"; mail-complaints-to="usenet@blaine.gmane.org" Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Alex Gramiak Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 12 21:15:15 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hF1dr-001008-80 for ged-emacs-devel@m.gmane.org; Fri, 12 Apr 2019 21:15:15 +0200 Original-Received: from localhost ([127.0.0.1]:41580 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hF1dq-0000vQ-1x for ged-emacs-devel@m.gmane.org; Fri, 12 Apr 2019 15:15:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53566) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hF1dj-0000v0-N2 for emacs-devel@gnu.org; Fri, 12 Apr 2019 15:15:08 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:39012) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hF1dj-0003Hr-BI; Fri, 12 Apr 2019 15:15:07 -0400 Original-Received: from [176.228.60.248] (port=3210 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hF1di-0004FJ-QS; Fri, 12 Apr 2019 15:15:07 -0400 In-reply-to: <8736mnvybp.fsf@gmail.com> (message from Alex Gramiak on Fri, 12 Apr 2019 13:05:30 -0600) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235364 Archived-At: > From: Alex Gramiak > Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org > Date: Fri, 12 Apr 2019 13:05:30 -0600 > > > Are you sure? I still see the code related to this being removed. > > That's part of the simplification of the code. Before it uses a > predicate procedure to check the value of x_gtk_use_old_file_dialog, > which I removed in favour of checking the variable directly. It also > used function pointers to wrapper procedures to get the filename, which > I removed in favour of calling the gtk procedures directly. The actual > old file dialog (xg_get_file_with_selection) is, in this patch, still > present. I tested again with GTK 2.24 and GTK 3.10 and it worked as > expected. Please don't simplify that part, but instead leave it alone. And why was the configure-time test related to that removed? Please also don't obsolete the variable, I see no reason to do that. In general, just leave that part out of the patch. Thanks.