From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Tabs Date: Thu, 10 Oct 2019 12:59:08 +0300 Message-ID: <83o8yosyz7.fsf@gnu.org> References: <20191008085604.tjtxm6ndyuluocbs@Ergus> <83lftvy4s6.fsf@gnu.org> <20191008160038.6xvnytnoruzphzd6@Ergus> <83zhibw6qn.fsf@gnu.org> <20191008164048.bnad4wdkcbatqepp@Ergus> <83v9szw4o4.fsf@gnu.org> <20191008234350.ahxt4zcylxqludoc@Ergus> <837e5ewc0a.fsf@gnu.org> <20191009103936.qjdwuidqnowswojw@Ergus> <83wodeup6a.fsf@gnu.org> <20191009120534.ud6st2xvrv3rv6iy@Ergus> <83pnj6umjx.fsf@gnu.org> <191fdb9e-a0ad-62d5-b214-fead90ec4bda@gmx.at> <83zhi9u57j.fsf@gnu.org> <53365bd1-96e0-feb1-362d-1d8b6a35450f@gmx.at> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="218793"; mail-complaints-to="usenet@blaine.gmane.org" Cc: spacibba@aol.com, juri@linkov.net, emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 10 11:59:56 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iIVEh-000uoI-Ri for ged-emacs-devel@m.gmane.org; Thu, 10 Oct 2019 11:59:55 +0200 Original-Received: from localhost ([::1]:35700 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIVEg-0000ab-Hb for ged-emacs-devel@m.gmane.org; Thu, 10 Oct 2019 05:59:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40142) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIVEE-0000aR-Cq for emacs-devel@gnu.org; Thu, 10 Oct 2019 05:59:27 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36209) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iIVEC-0002nr-Vu; Thu, 10 Oct 2019 05:59:25 -0400 Original-Received: from [176.228.60.248] (port=4918 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iIVEC-00080i-Bs; Thu, 10 Oct 2019 05:59:24 -0400 In-reply-to: <53365bd1-96e0-feb1-362d-1d8b6a35450f@gmx.at> (message from martin rudalics on Thu, 10 Oct 2019 11:15:55 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240825 Archived-At: > Cc: spacibba@aol.com, emacs-devel@gnu.org, juri@linkov.net > From: martin rudalics > Date: Thu, 10 Oct 2019 11:15:55 +0200 > > (3) Once the frame has been made and f->tool_bar_resized is set, the > latter is never reset again and it's really one-off in the sense > you described. Thanks. I will update the commentary for these members to reflect your description. > > No, I think the cause of the problem is that we have no equivalent of > > "C-x 6 f" that turns on the tool bar as a side effect of a command > > that displays a buffer. > > I'm missing you here. Do you mean that displaying a tool bar for the > first time in an Emacs session on a specific frame when you display a > certain buffer on that frame would have a similar dramatic effect? That's my current theory, yes. Although I'm nowhere near sure it's correct. > Couldn't you verify that? I don't know how. We don't have the equivalent of "C-x 6 f" that turns on a tool bar that was off before that, do we? > I'm still not entirely sure whether it was a good idea to cargo cult > the tab bar code from the tool bar code. As a first approximation, it wasn't a bad idea. But it needs various adjustments due to the tab-bar specifics (including, but not limited to, tab bar on TTY frames, where there's no "prior art" in tool-bar code), and that's what we are struggling with now. Also, the default GTK build has a tool bar that is displayed entirely unlike the tab bar, and that is another difficulty. Btw... why do we set frame_inhibit_implied_resize to nil in GTK builds? Shouldn't it be (tab-bar-lines) instead? The tab bar in GTK build uses our own window, doesn't it?