From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: scratch/sigchld-fd 8f0ce42 1/2: Fix deadlock when receiving
 SIGCHLD during 'pselect'.
Date: Sat, 23 Jan 2021 20:23:11 +0200
Message-ID: <83o8hf4ink.fsf@gnu.org>
References: <20210116184947.2105.45267@vcs0.savannah.gnu.org>
 <20210116184949.3C17C211A5@vcs0.savannah.gnu.org> <834kjd7yk5.fsf@gnu.org>
 <CAArVCkRg-mamb1YVgzQDYMRsR-CP=cD3OzGsLL3PzWykhi8Yog@mail.gmail.com>
 <83turc7n93.fsf@gnu.org>
 <CAArVCkRsx105TkpZZm+jnDzKOfpjWztNKGWB7KTtpgUhTaT_9A@mail.gmail.com>
 <83pn1z7inp.fsf@gnu.org>
 <CAArVCkSdUh1UFq0Y9gEe-D4+k4gTVQq-PSbvZy3rTg8gKU9aBw@mail.gmail.com>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="27375"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: phst@google.com, emacs-devel@gnu.org
To: Philipp Stephani <p.stephani2@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 23 19:23:54 2021
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1l3NZh-00071z-08
	for ged-emacs-devel@m.gmane-mx.org; Sat, 23 Jan 2021 19:23:53 +0100
Original-Received: from localhost ([::1]:34834 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1l3NZg-0004oC-1Y
	for ged-emacs-devel@m.gmane-mx.org; Sat, 23 Jan 2021 13:23:52 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44742)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1l3NZ1-0004NJ-Hl
 for emacs-devel@gnu.org; Sat, 23 Jan 2021 13:23:11 -0500
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45946)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1l3NZ1-0003wd-1d; Sat, 23 Jan 2021 13:23:11 -0500
Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4313
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1l3NZ0-0000xY-A6; Sat, 23 Jan 2021 13:23:10 -0500
In-Reply-To: <CAArVCkSdUh1UFq0Y9gEe-D4+k4gTVQq-PSbvZy3rTg8gKU9aBw@mail.gmail.com>
 (message from Philipp Stephani on Sat, 23 Jan 2021 18:36:48 +0100)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:263309
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/263309>

> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Sat, 23 Jan 2021 18:36:48 +0100
> Cc: Emacs developers <emacs-devel@gnu.org>, Philipp Stephani <phst@google.com>
> > Just making those child_signal_* function be no-ops on MS-Windows, and
> > #ifedf'ing away that call to FD_SET of child_fd, should be okay, I
> > think.
> 
> I was about to take a stab at this, but looks like you beat me to it :-)

Yes, I had a few free minutes.

Thanks anyway.

P.S. What about child_signal_read, which doesn't seem to be used by
any configuration? should we delete it?