From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Consistent face for keys in *Help* and `substitute-command-keys' Date: Sat, 13 Mar 2021 17:16:59 +0200 Message-ID: <83o8fnhyms.fsf@gnu.org> References: <83a6rhxwah.fsf@gnu.org> <837dmlxspt.fsf@gnu.org> <834khpxr0s.fsf@gnu.org> <8335x8ybw9.fsf@gnu.org> <87czwageno.fsf@mail.linkov.net> <878s6xwngp.fsf@mail.linkov.net> <874khjq6p8.fsf@mail.linkov.net> <875z1ylrdw.fsf@mail.linkov.net> <83eegmok4v.fsf@gnu.org> <834khins2i.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23339"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, emacs-devel@gnu.org, juri@linkov.net To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Mar 13 16:17:47 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lL61T-0005yL-DD for ged-emacs-devel@m.gmane-mx.org; Sat, 13 Mar 2021 16:17:47 +0100 Original-Received: from localhost ([::1]:50054 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lL61S-0007jx-71 for ged-emacs-devel@m.gmane-mx.org; Sat, 13 Mar 2021 10:17:46 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49596) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lL60e-0007Iy-Fc for emacs-devel@gnu.org; Sat, 13 Mar 2021 10:16:56 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34670) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lL60c-0005ZE-1G; Sat, 13 Mar 2021 10:16:54 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2833 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lL60b-0008RH-EO; Sat, 13 Mar 2021 10:16:53 -0500 In-Reply-To: (message from Stefan Kangas on Sat, 13 Mar 2021 08:27:05 -0600) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266432 Archived-At: > From: Stefan Kangas > Date: Sat, 13 Mar 2021 08:27:05 -0600 > Cc: larsi@gnus.org, juri@linkov.net, emacs-devel@gnu.org > > I was able to avoid any vertical resizing using the advice from Stefan M. > So I pushed the following change to master: > > modified lisp/faces.el > @@ -2816,8 +2816,12 @@ help-argument-name > :group 'help) > > (defface help-key-binding > - '((((class color) (min-colors 88) (background light)) :background "grey90") > - (((class color) (min-colors 88) (background dark)) :background "grey25") > + '((((class color) (min-colors 88) (background light)) > + :background "grey92" :foreground "DarkBlue" > + :box (:line-width (1 . -1) :color "grey80")) > + (((class color) (min-colors 88) (background dark)) > + :background "grey23" :foreground "LightBlue" > + :box (:line-width (1 . -1) :color "grey35")) > (((class color grayscale) (background light)) :background "grey90") > (((class color grayscale) (background dark)) :background "grey25") Thanks, but such non-trivial stuff should always be accompanied by a comment to explain why we do that. I added such a comment in this case, but please in the future make sure to leave a comment.