From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Bug-reference auto-setup for Rmail (please test) Date: Sun, 16 May 2021 11:52:54 +0300 Message-ID: <83o8dbukk9.fsf@gnu.org> References: <87eee75d8n.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10255"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Tassilo Horn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 16 10:54:59 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1liCY6-0002TF-Ru for ged-emacs-devel@m.gmane-mx.org; Sun, 16 May 2021 10:54:58 +0200 Original-Received: from localhost ([::1]:60614 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1liCY5-00007G-Uk for ged-emacs-devel@m.gmane-mx.org; Sun, 16 May 2021 04:54:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33238) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liCWA-00054f-ID for emacs-devel@gnu.org; Sun, 16 May 2021 04:52:58 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44736) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1liCW8-0006b2-NQ for emacs-devel@gnu.org; Sun, 16 May 2021 04:52:58 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4096 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liCW6-0005SH-NP; Sun, 16 May 2021 04:52:56 -0400 In-Reply-To: <87eee75d8n.fsf@gnu.org> (message from Tassilo Horn on Sun, 16 May 2021 09:23:21 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269335 Archived-At: > From: Tassilo Horn > Date: Sun, 16 May 2021 09:23:21 +0200 > > What you need to do is activate `bug-reference-mode' in Rmail, so > probably: > > (add-hook 'rmail-mode-hook #'bug-reference-mode) > > and then it'll try to guess the right `bug-reference-bug-regexp' and > `bug-reference-url-format' based on the List-Id, To, From, and Cc > headers according to the customize option > `bug-reference-setup-from-mail-alist' which should at least have a > suitable default value for (some) emacs-related mailinglists including > emacs-devel. Thanks, but it is not clear to me what this feature is supposed to do, and how do I test that. You say "it will try to guess", but what is the expression of that guesswork, from the user perspective? > There is one problem where I need implementation advice. The > bug-reference auto-setup is a no-op if `bug-reference-bug-regexp' and > `bug-reference-url-format' are already set (see > `bug-reference--run-auto-setup'). So if you view an emacs-devel message > first, it'll set those variables. When you move on to the next message > (which might be completely unrelated to emacs), the variables are still > set, so no new guesswork will be done. > > We'd need to nuke the buffer-local values and re-enable > `bug-reference-mode' on switching messages, e.g., > > (add-hook 'rmail-show-message-hook #'rmail-bug-reference-setup) > > for a yet to be written rmail-bug-reference-setup which is a bit sad > because for all other modes where I've added this auto-setup capability > (Gnus, Mu4e [currently only in my ~/.emacs], rcirc, ERC, VC) the > "normal" > > (add-hook '-hook #'bug-reference-mode) > > will do, that is, for Rmail the user would need to use a special > function rather than just enabling `bug-reference-mode' in the mode of > his choice. (Of course, this could be documented.) > > Alternatively, Rmail itself could check if `bug-reference-mode' is > enabled, nuke the two variables, and call > `bug-reference--run-auto-setup'. How is Rmail different in this regard from other MUA in Emacs? why do you need something special for Rmail and not for the rest? Thanks.