unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Zhiwei Chen <chenzhiwei03@kuaishou.com>
Cc: larsi@gnus.org, condy0919@gmail.com, emacs-devel@gnu.org
Subject: Re: Highlight current line when using gud
Date: Wed, 30 Jun 2021 16:17:51 +0300	[thread overview]
Message-ID: <83o8bnmqyo.fsf@gnu.org> (raw)
In-Reply-To: <6F39630A-1FF8-45DE-9E3B-D9E8BE906BD7@kuaishou.com> (message from Zhiwei Chen on Wed, 30 Jun 2021 12:53:08 +0000)

> From: Zhiwei Chen <chenzhiwei03@kuaishou.com>
> Date: Wed, 30 Jun 2021 12:53:08 +0000
> Cc: Condy Chen <condy0919@gmail.com>, emacs-devel <emacs-devel@gnu.org>
> 
> Case 1: Users don't use hl-line-mode.
> There will be no line highlighted in the source buffer.
> 
> Case 2: Users use `hl-line-mode' but set `hl-line-sticky-flag' to nil.
> In that case, current line will be highlighted if and only if the point is in the source buffer. But if people type “n”, “bt”, “c” ... in the gud buffer, the line in the source buffer will not be highlighted due to the nil `hl-line-sticky-flag’.
> 
> Case 3: Users use `hl-line-mode’ and set `hl-line-sticky-flag’ to t.
> It works well except that users should make sure `hl-line-face’ is distinguishable. For me (using doom-one theme), it’s hard to see the highlighted line.

But these are all user preferences, aren't they?  You have your
preferences, others have theirs.  No one said everyone needs to have
the current line highlighted in non-selected windows, even when
debugging.  It's up to the users whether they want it or not.

The question most important to me is: can you, with your preferences,
use hl-line-mode to produce the same effect as the patch you propose
would?  If yes, why do we need yet another user option?  And if you
cannot, can you explain why not?

Thanks.



  parent reply	other threads:[~2021-06-30 13:17 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-28 12:43 Highlight current line when using gud Zhiwei Chen
2021-06-29 20:00 ` Condy Chen
2021-06-30 11:54   ` Lars Ingebrigtsen
2021-06-30 12:27     ` Eli Zaretskii
2021-06-30 13:07       ` Zhiwei Chen
2021-06-30 12:53     ` Zhiwei Chen
2021-06-30 12:59       ` Zhiwei Chen
2021-06-30 13:18         ` Eli Zaretskii
2021-06-30 13:17       ` Eli Zaretskii [this message]
2021-06-30 14:26         ` Zhiwei Chen
2021-06-30 15:50           ` Eli Zaretskii
2021-07-01  3:17             ` Zhiwei Chen
2021-07-01 11:26           ` Lars Ingebrigtsen
2021-07-01 11:35             ` Zhiwei Chen
2021-07-01 17:27               ` Condy Chen
2021-07-01 18:25             ` Zhiwei Chen
2021-07-02 11:01               ` Lars Ingebrigtsen
2021-07-02 11:39                 ` Eli Zaretskii
2021-07-04  0:12                   ` Zhiwei Chen
2021-07-04  4:30                     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83o8bnmqyo.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=chenzhiwei03@kuaishou.com \
    --cc=condy0919@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).