From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: New optional Eshell module: em-elecslash Date: Wed, 20 Apr 2022 09:19:36 +0300 Message-ID: <83o80wtgxz.fsf@gnu.org> References: <87k0bokg98.fsf@melete.silentflame.com> <83ee1wzvki.fsf@gnu.org> <87fsmckd6d.fsf@melete.silentflame.com> <837d7oz0vo.fsf@gnu.org> <87wnfluiac.fsf@athena.silentflame.com> <87mtgg8uai.fsf@melete.silentflame.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7815"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, emacs-devel@gnu.org To: Sean Whitton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Apr 20 08:22:56 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nh3js-0001nJ-Gp for ged-emacs-devel@m.gmane-mx.org; Wed, 20 Apr 2022 08:22:56 +0200 Original-Received: from localhost ([::1]:49244 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nh3jr-0006Js-KH for ged-emacs-devel@m.gmane-mx.org; Wed, 20 Apr 2022 02:22:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38918) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nh3go-0003jn-HO for emacs-devel@gnu.org; Wed, 20 Apr 2022 02:19:46 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:57008) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nh3go-0000ZU-2V; Wed, 20 Apr 2022 02:19:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=hxWhj8qCK5R0f7rUdPhyI0VB5ji/Nfl/my/Ey/h9yuw=; b=ot048vDtZQNb sYb8z+6DFtNXzAiRM1YdOI1xqomfppyAvwEKiYyMuyMqsCwf9W/dVHCbAgCzLCegXh661u4a3mGiv UKtHJ+cFlIIqoAuXJZCYKNWHqwS0TwJZ8KmTZtjRA9aXX7otiJZKpPOzZk9RxbGDA/FbarVVdpvCn 6iF8rAG+nR3lY69Z4l/dtFr/4phZm1i8JTr2XalyYrFhr9M4/bI1Qq+SbA4mPViLjQWLk21PX21BF xr8NTnHxXag2ue8hICYsm9VCnZrTptlLfROAsago+91g00AH9/uMvTXveYUgb/aS3xWWyBb68L+N0 17DWYTRPa2R2qcIhTlg8yQ==; Original-Received: from [87.69.77.57] (port=4528 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nh3gm-0000Vd-HT; Wed, 20 Apr 2022 02:19:45 -0400 In-Reply-To: <87mtgg8uai.fsf@melete.silentflame.com> (message from Sean Whitton on Tue, 19 Apr 2022 17:36:53 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288695 Archived-At: > From: Sean Whitton > Cc: philipk@posteo.net > Date: Tue, 19 Apr 2022 17:36:53 -0700 > > Here is my revised patch. Much better, thanks. A few comments below. > +To help with supplying absolute file name arguments to remote > +commands, you can add the @code{eshell-elecslash} module to > +@code{eshell-modules-list}. Then, typing @kbd{/} as the first > +character of a command line argument will automatically insert the > +Tramp prefix @file{/method:host:}. If this is not what you want > +(e.g.@: because you want to refer to a local file) you can type ^ A comma is missing there. > + A limitation of the current > +implementation is that only the status as Lisp function or external > +program of the command at the very beginning of input can be > +considered. This sentence is unnecessarily hard to grasp. Note the passive tense and the fact that the important part is at the end, which are usually clear signs of sub-optimal wording. Please try to reword it, e.g. by swapping the first and the second parts. > -@item Make @kbd{/} electric > +@item Make @kbd{/} more electric > > -So that it automatically expands and corrects pathnames. Or make > -pathname completion for Pcomplete auto-expand @samp{/u/i/std@key{TAB}} to > +So that it automatically expands and corrects pathnames, beyond what > +the @code{em-elecslash} module is able to do. Or make pathname > +completion for Pcomplete auto-expand @samp{/u/i/std@key{TAB}} to This last paragraph needs a @noindent and should start with a lower-case letter, because it is a continuation of the previous sentence. Also, it uses "pathname(s)" where it should use "file name(s)". > +*** New module to help supplying absolute file names to remote commands. > +After enabling the new module, typing a forward slash as the first > +character of a command line argument will automatically insert the > +Tramp prefix. The automatic insertion applies only when > +'default-directory' is remote and the command is a Lisp function. > +This frees you from having to keep track of whether commands are Lisp > +function or external when supplying absolute file name arguments. See > +"Electric forward slash" in the Eshell manual. This NEWS entry should name the module, I think.