From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 5743b74d4b 1/2: Improve mouse dragging Date: Fri, 13 May 2022 15:48:20 +0300 Message-ID: <83o801mwdn.fsf@gnu.org> References: <83sfpfp5p1.fsf@gnu.org> <87sfpfx8j8.fsf@yahoo.com> <83ilqaq5o9.fsf@gnu.org> <87fsleykdp.fsf@yahoo.com> <83h75uq4id.fsf@gnu.org> <87bkw2yjeg.fsf@yahoo.com> <83ee0yq2pg.fsf@gnu.org> <8735hexoo3.fsf@yahoo.com> <83h75unf94.fsf@gnu.org> <87czghx67w.fsf@yahoo.com> <83a6blope5.fsf@gnu.org> <878rr5x46w.fsf@yahoo.com> <837d6poh7t.fsf@gnu.org> <87v8u9vgb6.fsf@yahoo.com> <83wnepmy7q.fsf@gnu.org> <874k1tvbx8.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8230"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri May 13 15:07:37 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1npV16-0001wJ-OZ for ged-emacs-devel@m.gmane-mx.org; Fri, 13 May 2022 15:07:36 +0200 Original-Received: from localhost ([::1]:54902 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1npV15-0000Bq-Jx for ged-emacs-devel@m.gmane-mx.org; Fri, 13 May 2022 09:07:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60520) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npUiN-00086F-Od for emacs-devel@gnu.org; Fri, 13 May 2022 08:48:15 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58438) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npUiN-00034C-ER; Fri, 13 May 2022 08:48:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=SalFHiwiPYywhwemWugO3sOaBdIdTutoog+hYlIYfRk=; b=DjIbTdpGJDh0 epfCnIluw3w6WzVZ8LW+Hp5ekJm38gJ0Z2CUsWb/3bmHFJcfLTI7XI7TByziZtRsEu0zPfjis/buc MBBzeYWVpDW0g8O5HhNAyhFZvbJn7zAlFJ/r/1tA4oXzDNhhcm5nda/fynOOpPBeacOuchuFDx07h NwQynA8/JLgeNBJWzukNiJb86noZWK97g90bUY+zMFTaottFSbvd1osvu4LZHwwmvLw1QaKBMXWJB CTajwaXnju2o/McWYkMx81hpRfZ5AtNETXG7HV/or2c5fKOt0kbX4EQMgDl7EZkYfmc+34HylDRKI 1nKGVYL93T35yD1j1P7S1A==; Original-Received: from [87.69.77.57] (port=4608 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npUiM-0004hE-UI; Fri, 13 May 2022 08:48:15 -0400 In-Reply-To: <874k1tvbx8.fsf@yahoo.com> (message from Po Lu on Fri, 13 May 2022 20:45:23 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289732 Archived-At: > From: Po Lu > Cc: emacs-devel@gnu.org > Date: Fri, 13 May 2022 20:45:23 +0800 > > Eli Zaretskii writes: > > > If we come up with a safe enough fix, we could consider backporting it > > to the release branch. > > I think the display issue is not serious enough to backport (and > probably can't be fixed safely). > > But the tooltip face overwriting the text completely prevents any > meaningful use of `mouse-drag-and-drop-region'. This is enough to fix > that bug alone: > > diff --git a/lisp/mouse.el b/lisp/mouse.el > index 1b9542b9b8..e5ea5475f4 100644 > --- a/lisp/mouse.el > +++ b/lisp/mouse.el > @@ -3049,7 +3049,7 @@ mouse-drag-and-drop-region > > ;; Show a tooltip. > (if mouse-drag-and-drop-region-show-tooltip > - (tooltip-show text-tooltip) > + (tooltip-show (copy-sequence text-tooltip)) > (tooltip-hide)) > > ;; Show cursor and highlight the original region. > > WDYT? This is okay for the release branch, thanks.