From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349) Date: Tue, 30 Aug 2022 20:02:38 +0300 Message-ID: <83o7w1u0k1.fsf@gnu.org> References: <166171593185.16640.41619657947456727@vcs2.savannah.gnu.org> <20220828194533.23A6BC00889@vcs2.savannah.gnu.org> <87r10znm0y.fsf@gnus.org> <83fshfvvyn.fsf@gnu.org> <999d1cb2-6b7f-8020-5202-e919278d895e@yandex.ru> <83v8q9u1q8.fsf@gnu.org> <87a67ladep.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30947"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dgutov@yandex.ru, ams@gnu.org, juri@jurta.org, emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 30 19:17:15 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oT4rT-0007ql-K4 for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Aug 2022 19:17:15 +0200 Original-Received: from localhost ([::1]:41466 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oT4rS-00043r-FG for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Aug 2022 13:17:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55170) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT4d2-0006lq-2B for emacs-devel@gnu.org; Tue, 30 Aug 2022 13:02:25 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55224) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT4d1-0001d7-34; Tue, 30 Aug 2022 13:02:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=bd+49L079nGF0nkNJRDUROPREk6DiiL942utR+Kvy+8=; b=NEdZIZ814i7L LZUPMto2o/6iXYFmQpYocmOPMBQTAF9UMFb5N+2dbleQDLAVT2njf9dfiOd/aLt4jVFKlEijEp/TL xNeM0iyPXDaaygRo99cNdMzloY/Epo92xUQFkDDJR/NdTP++O9vRXLe3Eo6iEs0npfO2t8Iom3prB KZ3RauOEIndad3NabnZ1IaxQ71yy29zT9yQXk7MI8w7Sdz4sgTbeQuqnXVHTM7tcL0VfezCqLHoIq eblMro2ewuF08hl9TU1NKLNDs5hYRuSG6diVqLFEpIHYovt2zLxOauQQNPXSToXqu5LoFBUJj1pRZ eaD0ew0EjfQqlT/yfOMetQ==; Original-Received: from [87.69.77.57] (port=2869 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT4cx-0002u6-MO; Tue, 30 Aug 2022 13:02:17 -0400 In-Reply-To: <87a67ladep.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 30 Aug 2022 18:45:18 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294367 Archived-At: > From: Lars Ingebrigtsen > Cc: Dmitry Gutov , ams@gnu.org, juri@jurta.org, > emacs-devel@gnu.org > Date: Tue, 30 Aug 2022 18:45:18 +0200 > > Eli Zaretskii writes: > > > I think the "C-x v D" step should be part of the command's execution. > > It makes little sense to me to ask the user to prepare the diffs in > > advance, since conceptually the changes are already on disk. > > It's just an easy way to decide which changes are part of this commit. I didn't say it shouldn't be displayed, I said the user shouldn't be required to prepare this display manually; the command should do it instead. > > I think a special numeric argument (like "C-u 0", perhaps?) is more > > appropriate to signal the interactive selection of changes. > > And then it asks you for every hunk whether to include it in the commit > or not? And then show a message to the user saying something like Edit the diffs to leave only the hunks you want to commit, then type C-c to go ahead and commit them.