From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: noverlay branch Date: Sat, 08 Oct 2022 09:57:22 +0300 Message-ID: <83o7umls4t.fsf@gnu.org> References: <83pmfill6l.fsf@gnu.org> <87illaffm5.fsf@localhost> <838rm6ktxp.fsf@gnu.org> <87v8ovdosz.fsf@localhost> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35942"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Ihor Radchenko Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Oct 08 08:59:00 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oh3nX-00099B-TC for ged-emacs-devel@m.gmane-mx.org; Sat, 08 Oct 2022 08:58:59 +0200 Original-Received: from localhost ([::1]:40560 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oh3nW-0008R0-Er for ged-emacs-devel@m.gmane-mx.org; Sat, 08 Oct 2022 02:58:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51956) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oh3ly-0007Es-1m for emacs-devel@gnu.org; Sat, 08 Oct 2022 02:57:22 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41602) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oh3lx-0007xR-Cj; Sat, 08 Oct 2022 02:57:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=4HkIJKhDbS6f25M9vS6zmEKRMCkvbvNZIH+Zzwcs4EI=; b=b30rZSh1PCxV xpJxjo5dUPxD3HeH5FfnlxXWrviTEW3otfz8OWT4UgHSvdXd8eqF9Id/wcSiqQ8orVqqWqJW9oRKW 9mo/jts57jA1bZTfMiYDGbbGXV3FX1YZU/SJqhYHC9fjm1jZUvoO4z1IAUx/HFJ3L2HBpCYeSrYYe jspjdfL9N6Yrr82RcyQNpYbZ4nSSVvnZF8ZZKkYnjFlojs72flTd9Mj2BkbgP4DgQ/J9hcXck21dI TG7hMMxnCEfmn4zJiAHmk+2wlla2WjLv4U8+gqPF9Wr8g0qjtt2XM5PKyk4zwtADtVLNMW1YOLr7N XnYEmE6BxddQp/fHp65jwA==; Original-Received: from [87.69.77.57] (port=1915 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oh3lw-00070X-Mn; Sat, 08 Oct 2022 02:57:21 -0400 In-Reply-To: <87v8ovdosz.fsf@localhost> (message from Ihor Radchenko on Sat, 08 Oct 2022 10:36:28 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297194 Archived-At: > From: Ihor Radchenko > Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org > Date: Sat, 08 Oct 2022 10:36:28 +0800 > > There are a couple of glitches though: > 1. hl-line-mode overlay sometimes disappear > 2. notmuch search buffer hides text in wrong places (see the attached video) > > Should I report these things as proper bugs or is it OK to discuss them > within this thread? Separate bug reports, please. And please mention there that the bugs pertain to the noverlay branch. Thanks. > Also, I did a small test comparing Org mode folding performance (using > overlays) on master vs feature/noverlay branch using the methodology > described in https://blog.tecosaur.com/tmio/2022-05-31-folding.html: > > On large 20Mb Org file using built-in Org version: > > master: Elapsed time: 142.940028s (1.428150s in 55 GCs) > feature/noverlay: Elapsed time: 4.369854s (1.451378s in 74 GCs) > > for comparison, the Org version from main yields: > > Emacs master: > - main Org branch using text properties for folding: Elapsed time: 2.185786s (0.639190s in 4 GCs) > - main Org branch using overlays for folding: Elapsed time: 27.244284s (0.731581s in 5 GCs) > > Emacs feature/noverlay: > - main Org branch using text properties for folding: Elapsed time: 1.586936s (0.476606s in 3 GCs) > - main Org branch using overlays for folding: Elapsed time: 2.039803s (0.724576s in 5 GCs) > > The improvement is very significant. Thanks, looks very encouraging. > We also have tests for marker scaling. If the overlay tree > implementation can be reused for markers, it would also be great. Not in Emacs 29, I'm afraid.