From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master c69858b3f0: ; * lisp/treesit.el (treesit-ready-p): Guard against empty buffers. Date: Wed, 23 Nov 2022 14:27:48 +0200 Message-ID: <83o7sxzwhn.fsf@gnu.org> References: <166916717199.12853.3816069320355351676@vcs2.savannah.gnu.org> <20221123013252.46814C004B6@vcs2.savannah.gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2427"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, casouri@gmail.com To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 23 13:28:31 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxorc-0000HZ-SD for ged-emacs-devel@m.gmane-mx.org; Wed, 23 Nov 2022 13:28:29 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxoqn-0000WS-Aw; Wed, 23 Nov 2022 07:27:37 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxoqm-0000Vc-CU for emacs-devel@gnu.org; Wed, 23 Nov 2022 07:27:36 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxoqj-0004rP-0T; Wed, 23 Nov 2022 07:27:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=rocM1uGNNcGrqVaSomvLfo7krFyszaKkxsGQ0NGa0fk=; b=AL/8KdJsIY5k DEULshOBLzcDcrIhzVCQJIICsvFows5Xk/sNieSe82DMeI/9+6Ckbwn7YZ9eBY7LMlB9N5a33+3Fl FDdeWcB7Dsx3fzCHHzwjYRJFoYKYwzx3YGVCA3vy2XBjJsLor2Cp2c9Fy3pm8klU8mKYK4oB0xj2I KaZCxclIHLkWbw2LDEnCFcg/Fd9H1Ko6nCiTsp3Kd42Zo0mFuMKVdsm++dEzp0m20iYg/SbqtRgmh Otuq/7ofkf/lOzpJlkSSD+b0hJvBJUHGwNXR/Z1W1W60F8VbU6Fqzo3q82+7O/Vz0mfBeNK/pcdW/ Vulgh8GRV2Oj8GIwdLY8/g==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxoqi-0003rb-Cn; Wed, 23 Nov 2022 07:27:32 -0500 In-Reply-To: (message from Stefan Monnier on Tue, 22 Nov 2022 20:51:40 -0500) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300388 Archived-At: > From: Stefan Monnier > Cc: Yuan Fu > Date: Tue, 22 Nov 2022 20:51:40 -0500 > > > - (when (> (position-bytes (1- (point-max))) treesit-max-buffer-size) > > + (when (> (position-bytes (max (point-min) (1- (point-max)))) > > + treesit-max-buffer-size) > > I'd expect `treesit-max-buffer-size` to be compared to `buffer-size` > rather than to buffer positions. Please tell more: what problems do you see with the above, and why? It is not easy to guess what's on your mind.