From: Eli Zaretskii <eliz@gnu.org>
To: Lynn Winebarger <owinebar@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Regression in dump-emacs-portable
Date: Thu, 16 Feb 2023 17:46:41 +0200 [thread overview]
Message-ID: <83o7pt395q.fsf@gnu.org> (raw)
In-Reply-To: <CAM=F=bCU_nXBFNCL9mj1fUdf9T2nNZDeqLmdzKtRO23Oo-bNgw@mail.gmail.com> (message from Lynn Winebarger on Thu, 16 Feb 2023 04:31:10 -0500)
> From: Lynn Winebarger <owinebar@gmail.com>
> Date: Thu, 16 Feb 2023 04:31:10 -0500
> Cc: emacs-devel <emacs-devel@gnu.org>
>
> > Almost every library in 28.2 could be redumped, excepting those which
> > simply failed to load for whatever reason.
>
> Don't we have Lisp objects that cannot be dumped? If we do, then not
> every library could be dumped even in principle.
>
> In 28.2, using dump-emacs-portable, the answer is, not many in the libraries in included in the Emacs
> source distribution. I excluded the term and obsolete subdirectories from generating the set of libraries to
> dump (but not from the final set determined from load-history).
Is exclusion really the way to go, if we want eventually to support
re-dumping at any given moment?
> Another potential issue with this is (assuming you suggest to actually
> try dumping every library) that it will take too long, and thus will
> be likely to be skipped in any "normal" run of the test suite, thus
> missing the point.
>
> My 2017-vintage laptop dumps the 1252 files, including all of leim, in 34 seconds, for a 135MB dump file.
> When I added leim to the exclusions list, 1172 libraries are dumped in 24 seconds for a 83MB dump file,
> which explains why my effort with 30.0.50 produces a 75MB dump.
That's a lot. And I presume your build is optimized? So an
unoptimized build will be slower. Running such slow tests routinely
is a PITA, so such a test will probably moved to a category that
doesn't run by default.
> Aside from testing on a per-commit basis, isn't there a
> more comprehensive set of regression tests run pre-release? Does emacs have a CI process regularly
> running the test suite, or is it more ad hoc?
There's EMBA.
next prev parent reply other threads:[~2023-02-16 15:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 0:51 Regression in dump-emacs-portable Lynn Winebarger
2023-02-14 1:13 ` Lynn Winebarger
2023-02-14 14:23 ` Eli Zaretskii
2023-02-14 23:26 ` Lynn Winebarger
2023-02-15 12:42 ` Eli Zaretskii
2023-02-16 9:31 ` Lynn Winebarger
2023-02-16 9:54 ` Lynn Winebarger
2023-02-16 15:05 ` Lynn Winebarger
2023-02-16 15:34 ` Eli Zaretskii
2023-02-16 23:45 ` Lynn Winebarger
2023-02-17 13:22 ` Lynn Winebarger
2023-02-17 14:31 ` Eli Zaretskii
2023-02-17 23:44 ` Lynn Winebarger
2023-02-18 7:07 ` Eli Zaretskii
2023-02-21 14:21 ` Lynn Winebarger
2023-02-23 2:41 ` Lynn Winebarger
2023-02-23 13:21 ` Lynn Winebarger
2023-02-16 15:46 ` Eli Zaretskii [this message]
2023-02-17 1:29 ` Lynn Winebarger
2023-02-17 3:19 ` Lynn Winebarger
2023-02-17 4:10 ` Lynn Winebarger
2023-02-17 5:21 ` Po Lu
2023-02-17 12:57 ` Lynn Winebarger
2023-02-23 15:08 ` Gregory Heytings
2023-02-23 22:32 ` Lynn Winebarger
2023-02-25 4:11 ` Richard Stallman
2023-02-25 4:11 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83o7pt395q.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=owinebar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).