From: Eli Zaretskii <eliz@gnu.org>
To: Ruijie Yu <ruijie@netyu.xyz>
Cc: jporterbugs@gmail.com, emacs-devel@gnu.org
Subject: Re: master d3ec68f5e43: ; Fix post-commit and pre-push hooks in worktrees again
Date: Fri, 05 May 2023 08:12:18 +0300 [thread overview]
Message-ID: <83o7mzjr9p.fsf@gnu.org> (raw)
In-Reply-To: <sdvr0rvfnqt.fsf@netyu.xyz> (emacs-devel@gnu.org)
> Cc: Emacs developers <emacs-devel@gnu.org>
> Date: Fri, 05 May 2023 11:28:43 +0800
> From: Ruijie Yu via "Emacs development discussions." <emacs-devel@gnu.org>
>
> $ grep --line-number -e abs_ Makefile
> 192:abs_srcdir=/opt/src/emacs/base/emacs-30
> 266:buildlisppath=${abs_srcdir}/lisp
> 461: @for dir in '$(abs_srcdir)' '$(lispdir)' '$(archlibdir)'; do \
> 497: @(w32srcdir=`${srcdir}/build-aux/msys-to-w32 "${abs_srcdir}"`; \
> --8<---------------cut here---------------end--------------->8---
>
> Notice that lines 461 and 497 protects against spaces (presumably),
> whereas line 266 doesn't. If we do expect spaces in git root, line 266
> might be an issue.
Quoting of file names is needed in command lines, not in assignments
of values to Make variables. Make doesn't have a problem with
variable values that include whitespace. It's the shell that needs
quoting.
So line 266 cannot be the problem, but any command line that uses
$buildlisppath might be.
prev parent reply other threads:[~2023-05-05 5:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <168321910568.3995.3571437191907192632@vcs2.savannah.gnu.org>
[not found] ` <20230504165146.0F159C22EE0@vcs2.savannah.gnu.org>
2023-05-05 3:28 ` master d3ec68f5e43: ; Fix post-commit and pre-push hooks in worktrees again Ruijie Yu via Emacs development discussions.
2023-05-05 4:06 ` Jim Porter
2023-05-05 5:23 ` Po Lu
2023-05-05 5:45 ` Jim Porter
2023-05-05 6:16 ` Po Lu
2023-05-05 5:12 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83o7mzjr9p.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=jporterbugs@gmail.com \
--cc=ruijie@netyu.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).