unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: arthur.miller@live.com, gregory@heytings.org, emacs-devel@gnu.org
Subject: Re: Make window-list return windows for all frames
Date: Sat, 17 Jun 2023 11:39:35 +0300	[thread overview]
Message-ID: <83o7leqy7s.fsf@gnu.org> (raw)
In-Reply-To: <e694d225-7249-3981-597f-12eb31c0dddc@gmx.at> (message from martin rudalics on Fri, 16 Jun 2023 16:21:54 +0200)

> Date: Fri, 16 Jun 2023 16:21:54 +0200
> Cc: gregory@heytings.org, emacs-devel@gnu.org
> From: martin rudalics <rudalics@gmx.at>
> 
>  >> Yes, window-list and window-list-1 becaomes the same, just with arguments in
>  >> different order. Could even remove c version of window-list, and implement it as
>  >> a call to window-list-1. Less code, less maintanance.
>  >
>  > Martin, are there any reason we'd not want window-list to accept t as
>  > the FRAME argument?
> 
> None on my side.  The current implementation of 'window-list' simply
> throws an error for (window-list t).  Back then I made 'window-list-1' a
> separate function because with
> 
> (defvar frame-1 (selected-frame))
> (defvar window-2 (frame-root-window (make-frame)))
> 
> calling
> 
> (window-list frame-1 nil window-2)
> 
> complains while
> 
> (window-list-1 window-2 nil frame-1)
> 
> doesn't.  People were picky about such issues in the past.

Thanks.  then I guess we can install (on master) the patch which makes
window-list accept t as the FRAME argument.



  reply	other threads:[~2023-06-17  8:39 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-15 12:41 Make window-list return windows for all frames Arthur Miller
2023-06-15 13:09 ` Eli Zaretskii
2023-06-15 14:01   ` Arthur Miller
2023-06-15 15:22     ` Eli Zaretskii
2023-06-15 16:32       ` Arthur Miller
2023-06-16  7:29         ` Gregory Heytings
2023-06-16 10:03           ` Arthur Miller
2023-06-16 10:34             ` Eli Zaretskii
2023-06-16 14:21               ` martin rudalics
2023-06-17  8:39                 ` Eli Zaretskii [this message]
2023-06-17  9:39                   ` martin rudalics
2023-06-17 10:42                     ` Eli Zaretskii
2023-06-18 13:36                       ` Arthur Miller
2023-06-19  6:55                       ` Arthur Miller
2023-06-20  6:25                         ` martin rudalics
2023-06-27 16:44                           ` Arthur Miller
2023-06-15 16:11     ` [External] : " Drew Adams
2023-06-15 17:18       ` Arthur Miller
2023-06-15 13:12 ` Gregory Heytings
2023-06-15 14:04   ` Arthur Miller
2023-06-15 14:19     ` Gregory Heytings
2023-06-15 16:19       ` Arthur Miller
2023-06-15 17:15         ` Gregory Heytings
2023-06-15 17:53           ` Arthur Miller
2023-06-15 13:50 ` Po Lu
2023-06-15 18:02   ` Arthur Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83o7leqy7s.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=arthur.miller@live.com \
    --cc=emacs-devel@gnu.org \
    --cc=gregory@heytings.org \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).