From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Android port Date: Sun, 06 Aug 2023 16:05:10 +0300 Message-ID: <83o7jkpbi1.fsf@gnu.org> References: <1428589171.162865.1691134964773@mail1.libero.it> <3473524.ldcX8TXnAK@nimes> <83fs4xslst.fsf@gnu.org> <6358080.k4LH7P0x6x@nimes> <83edkhskyq.fsf@gnu.org> <87jzu97hu2.fsf@yahoo.com> <835y5tse75.fsf@gnu.org> <83zg35qz7m.fsf@gnu.org> <87cz016oxn.fsf@yahoo.com> <83msz4rcil.fsf@gnu.org> <878rao7o8o.fsf@yahoo.com> <83h6pcrbe9.fsf@gnu.org> <87v8ds5xr4.fsf@yahoo.com> <838raoqzro.fsf@gnu.org> <87r0og5wzt.fsf@yahoo.com> <83350wqzci.fsf@gnu.org> <87msz45wd1.fsf@yahoo.com> <831qggqyln.fsf@gnu.org> <87il9s5vmv.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20508"; mail-complaints-to="usenet@ciao.gmane.io" Cc: eggert@cs.ucla.edu, bruno@clisp.org, angelo.g0@libero.it, emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Aug 06 15:05:36 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qSdRv-00052w-Mn for ged-emacs-devel@m.gmane-mx.org; Sun, 06 Aug 2023 15:05:35 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qSdRK-0008IR-Cn; Sun, 06 Aug 2023 09:04:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSdRI-0008I9-Tk for emacs-devel@gnu.org; Sun, 06 Aug 2023 09:04:57 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSdRG-0007Wv-RL; Sun, 06 Aug 2023 09:04:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=7GA4Jm7QNDAT2Lgdi/3Yg5TYtQ4dOwjN6EMPYqAx/YQ=; b=R1qZo7GKLpVt D1Qo8zFOlcRi+CDpGMZeYHOS13WhOxLV5X6Dyk07fiD3KWcbWLeRMIYBvfTbYBQmdeA1xZHOxiCb0 UIAUDTD0xTOm/4Ll+HdamBP1cNr5mCv/oK61dKgmAPG/8K+dBGq5ecx9tkQjQchfrwcbDRp7PFdv5 64EroHrvEKym8Zd/YHZeED+pjabtzT+wJxyG6Uq7fq92HrLSNGoSOjdRRZK54ACaYCEBcRAqw/6VA tmuqE9q/euuOzUEyMBLMWzx1oB2K3SF1BshTf74WWyrTld2RwMO0VANGYH9lFHfg4LD0njiwOgVT2 mB3RwChxDI/VE+xE97gabw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSdRG-0005bJ-11; Sun, 06 Aug 2023 09:04:54 -0400 In-Reply-To: <87il9s5vmv.fsf@yahoo.com> (message from Po Lu on Sun, 06 Aug 2023 18:10:32 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308362 Archived-At: > From: Po Lu > Cc: eggert@cs.ucla.edu, bruno@clisp.org, angelo.g0@libero.it, > emacs-devel@gnu.org > Date: Sun, 06 Aug 2023 18:10:32 +0800 > > diff --git a/nt/mingw-cfg.site b/nt/mingw-cfg.site > index 425eaace30d..f78ee525bf1 100644 > --- a/nt/mingw-cfg.site > +++ b/nt/mingw-cfg.site > @@ -173,3 +173,21 @@ gl_cv_func_nanosleep=yes > # Suppress configure-time diagnostic from unnecessary libxattr check, > # as xattr will not be supported here. > enable_xattr=no > +# Don't build gnulib printf either. > +gl_cv_func_printf_sizes_c99=yes > +gl_cv_func_printf_sizes_c23=yes > +gl_cv_func_printf_long_double=yes > +gl_cv_func_printf_infinite_long_double=yes > +gl_cv_func_printf_directive_a=yes > +gl_cv_func_printf_directive_b=yes > +gl_cv_func_printf_directive_f=yes > +gl_cv_func_printf_directive_n=yes > +gl_cv_func_printf_directive_ls=yes > +gl_cv_func_printf_directive_lc=yes > +gl_cv_func_printf_positions=yes > +gl_cv_func_printf_flag_grouping=yes > +gl_cv_func_printf_flag_leftadjust=yes > +gl_cv_func_printf_flag_zero=yes > +gl_cv_func_printf_precision=yes > +gl_cv_func_printf_enomem=yes > +ac_cv_func_vasprintf=yes > > Both the check for vasprintf (Gnulib eschews testing for asprintf, since > asprintf is never present where vasprintf is not) and the checks for > printf features are overridden, because Gnulib also tries to replace > vasprintf if it discovers that the conventional printf functions will > need to be replaced. According to my reading of vasprintf.m4, if ac_cv_func_vasprintf=yes, the rest of the tests, including adding asprintf to LIBOBJ, should not have happened: AC_DEFUN([gl_FUNC_VASPRINTF], [ AC_CHECK_FUNCS([vasprintf]) if test $ac_cv_func_vasprintf = no; then <<<<<<<<<<<<<<<<<< gl_REPLACE_VASPRINTF fi ]) Or, if we are using vasprintf-posix.m4 (are we?), then gl_cv_func_vasprintf_posix should have done that: AC_DEFUN([gl_FUNC_VASPRINTF_POSIX], [ AC_REQUIRE([gl_FUNC_VASPRINTF_IS_POSIX]) if test $gl_cv_func_vasprintf_posix = no; then <<<<<<<<<<<<<<<<<<< gl_PREREQ_VASNPRINTF_WITH_POSIX_EXTRAS gl_REPLACE_VASNPRINTF gl_REPLACE_VASPRINTF fi ]) I see that gl_cv_func_vasprintf_posix is not in your patch to mingw-cfg.site, so maybe adding that is all that's needed to avoid overriding all the other gl_cv_func_printf_* variables?