unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Dan Nicolaescu <dann@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: setpgrp on msdos and w32
Date: Mon, 15 Nov 2010 18:13:22 +0200	[thread overview]
Message-ID: <83mxpad0pp.fsf@gnu.org> (raw)
In-Reply-To: <yxqhbfj13n1.fsf@fencepost.gnu.org>

> From: Dan Nicolaescu <dann@gnu.org>
> Date: Mon, 15 Nov 2010 01:50:58 -0500
> 
> Does setpgrp do anything in our msdos and w32 ports?

No.  You will see a no-op emulation of setpgrp in w32.c (for w32); the
C library used to build the MSDOS port does not even have an emulation.

> The #else branch of this code from callproc.c:child_setup
> 
> #if defined(USG)
> #ifndef SETPGRP_RELEASES_CTTY
>   setpgrp ();                   /* No arguments but equivalent in this case */
> #endif
> #else
>   setpgrp (pid, pid);
> #endif /* USG */
> 
> might be executed on msdos and w32.

It isn't, because neither of these 2 builds defines USG.

> If setpgrp does not do anything, this code can be moved inside the not WINDOWSNT and not MSDOS 
> #ifdefs, and that would allow all the code from that point to the end of the function to move
> up, removing one set of #ifdefs.

Yes, feel free to do that.  Thanks.



      reply	other threads:[~2010-11-15 16:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-15  6:50 setpgrp on msdos and w32 Dan Nicolaescu
2010-11-15 16:13 ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83mxpad0pp.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=dann@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).