From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [RFC-2] Add tty True Color support. Date: Thu, 17 Oct 2013 19:56:49 +0300 Message-ID: <83mwm7omy6.fsf@gnu.org> References: <83wqldngnk.fsf@gnu.org> <2026164.mh4ZqmuNeq@descartes> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE X-Trace: ger.gmane.org 1382029021 6307 80.91.229.3 (17 Oct 2013 16:57:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 17 Oct 2013 16:57:01 +0000 (UTC) Cc: emacs-devel@gnu.org To: =?utf-8?Q?R=C3=BCdiger?= Sonderfeld Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 17 18:57:05 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VWqsi-00029x-97 for ged-emacs-devel@m.gmane.org; Thu, 17 Oct 2013 18:57:04 +0200 Original-Received: from localhost ([::1]:53447 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWqsh-0008A7-T3 for ged-emacs-devel@m.gmane.org; Thu, 17 Oct 2013 12:57:03 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59870) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWqsZ-00089j-Re for emacs-devel@gnu.org; Thu, 17 Oct 2013 12:57:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VWqsT-0000RW-3M for emacs-devel@gnu.org; Thu, 17 Oct 2013 12:56:55 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:56221) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWqsS-0000RA-Rm for emacs-devel@gnu.org; Thu, 17 Oct 2013 12:56:49 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MUT00500OEJPS00@a-mtaout20.012.net.il> for emacs-devel@gnu.org; Thu, 17 Oct 2013 19:56:47 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MUT005GKOEMLI40@a-mtaout20.012.net.il>; Thu, 17 Oct 2013 19:56:47 +0300 (IDT) In-reply-to: <2026164.mh4ZqmuNeq@descartes> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.166 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:164267 Archived-At: > From: R=C3=BCdiger Sonderfeld > Cc: emacs-devel@gnu.org > Date: Thu, 17 Oct 2013 00:39:23 +0200 >=20 > > I might be missing something, but it looks like you didn't make a= ny > > changes aimed at having display-color-cells report the correct nu= mber > > of colors for this type of terminal. If that is true, please add= some > > code to fix that, otherwise various parts in Emacs might behave > > incorrectly; for starters, defface's that define colors based on = how > > many colors are available will use the wrong colors. >=20 > I changed `tty-display-color-cells' to return the correct number. = See the > updated patch below. Thanks. > Do you have any suggestion how to do the terminal detection? So fa= r Thomas > Dickey seems to be reluctant to add support to terminfo. Maybe the= re could > be a lisp function to detect it, which could be easily adjusted by = the user. > But then again `init_tty' can be called very early in the start up = process. Can you do something similar to what terminal-init-xterm does for xterm?