From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Patches with independent changes Date: Sat, 25 Jan 2014 19:25:19 +0200 Message-ID: <83mwikas8w.fsf@gnu.org> References: <8361pbg5vy.fsf@gnu.org> <52E08D31.3080801@cs.ucla.edu> <8338kffj7m.fsf@gnu.org> <52E0A0ED.4020601@cs.ucla.edu> <83y526el6z.fsf@gnu.org> <52E18EC0.7090302@cs.ucla.edu> <83lhy5ests.fsf@gnu.org> <52E2277B.9000205@cs.ucla.edu> <83bnz1eo1x.fsf@gnu.org> <52E29827.7060209@cs.ucla.edu> <83ha8tcb4z.fsf@gnu.org> <52E2EA7B.2080501@cs.ucla.edu> <83fvoccyqt.fsf@gnu.org> <52E3EDE1.9050709@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1390670740 2139 80.91.229.3 (25 Jan 2014 17:25:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 25 Jan 2014 17:25:40 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 25 18:25:46 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W76zJ-0005QI-Pn for ged-emacs-devel@m.gmane.org; Sat, 25 Jan 2014 18:25:45 +0100 Original-Received: from localhost ([::1]:52024 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W76zJ-0002Vh-87 for ged-emacs-devel@m.gmane.org; Sat, 25 Jan 2014 12:25:45 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52926) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W76zC-0002Ui-Ll for emacs-devel@gnu.org; Sat, 25 Jan 2014 12:25:43 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W76z7-0005va-Hq for emacs-devel@gnu.org; Sat, 25 Jan 2014 12:25:38 -0500 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:39943) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W76z7-0005vR-3C for emacs-devel@gnu.org; Sat, 25 Jan 2014 12:25:33 -0500 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0MZY00J00WC6D600@a-mtaout23.012.net.il> for emacs-devel@gnu.org; Sat, 25 Jan 2014 19:25:31 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MZY00JGUWEJC220@a-mtaout23.012.net.il>; Sat, 25 Jan 2014 19:25:31 +0200 (IST) In-reply-to: <52E3EDE1.9050709@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.175 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:169070 Archived-At: > Date: Sat, 25 Jan 2014 09:01:21 -0800 > From: Paul Eggert > Cc: emacs-devel@gnu.org > > --- update-game-score.c-old 2014-01-25 08:31:13.065305429 -0800 > +++ update-game-score.c 2014-01-25 08:31:54.337506871 -0800 > @@ -443,8 +443,13 @@ > fd = mkostemp (tempfile, 0); > if (fd < 0) > return -1; > +#ifdef WINDOWSNT > + if (chmod (tempfile, 0644) != 0) > + return -1; > +#else > if (fchmod (fd, 0644) != 0) > return -1; > +#endif > f = fdopen (fd, "w"); > if (! f) > return -1; This code is plain wrong: you cannot chmod a file that is open, if you try, the chmod call will fail. Again, I just restored the old code, but only for WINDOWSNT. The reason for that was that I wanted a safe change, since we are in a feature freeze. In any case, the fact that the problem could have been solved in more than one way doesn't mean there are multiple changes involved.