Fixes: in vc for git?

Fixes: in vc for git?

[Jan D.]

Hello.

Is there a way to get the automatix Fixes: <bugno> in *vc-log* like we 
had for bzr?

Thanks,

	Jan D.

Re: Fixes: in vc for git?

[Eric S. Raymond]

Jan D. <jan.h.d@swipnet.se>:
> Is there a way to get the automatix Fixes: <bugno> in *vc-log* like
> we had for bzr?

Not in git itself. Our best option would be to buld something equivalent
into VC or Magit.
-- 
		<a href="http://www.catb.org/~esr/">Eric S. Raymond</a>

Re: Fixes: in vc for git?

[David Caldwell]

[-- Attachment #1: Type: text/plain, Size: 361 bytes --]

On 11/14/14 5:59 AM, Eric S. Raymond wrote:
> Jan D. <jan.h.d@swipnet.se>:
>> Is there a way to get the automatix Fixes: <bugno> in *vc-log* like
>> we had for bzr?
> 
> Not in git itself. Our best option would be to buld something equivalent
> into VC or Magit.

One could also add a git post-receive hook in the master repo to do this.

-David



[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4219 bytes --]

Re: Fixes: in vc for git?

[Glenn Morris]

"Jan D." wrote:

> Is there a way to get the automatix Fixes: <bugno> in *vc-log* like we
> had for bzr?

AFAICS, it Just Works by default?
(Thanks to log-edit-rewrite-fixes in dir-locals.el.
The only difference is that Fixes: is not converted to --fixes,
since git doesn't have that, but passed unchanged into the commit log.)

Re: Fixes: in vc for git?

[Stefan Monnier]

> (Thanks to log-edit-rewrite-fixes in dir-locals.el.
> The only difference is that Fixes: is not converted to --fixes,
> since git doesn't have that, but passed unchanged into the commit log.)

FWIW, I'm not convinced this counts as "it just works".  It looks pretty
ugly (more ugly than a "(bug#NN)" somewhere in the commit message).
I'd rather have it moved to the end of the commit message, for example.


        Stefan

Re: Fixes: in vc for git?

[Jan D.]

> 16 nov 2014 kl. 02:46 skrev Glenn Morris <rgm@gnu.org>:
> 
> "Jan D." wrote:
> 
>> Is there a way to get the automatix Fixes: <bugno> in *vc-log* like we
>> had for bzr?
> 
> AFAICS, it Just Works by default?
> (Thanks to log-edit-rewrite-fixes in dir-locals.el.
> The only difference is that Fixes: is not converted to --fixes,
> since git doesn't have that, but passed unchanged into the commit log.)

Is this a local addition you have?  There is no such thing in my unmodified .dir-locals.el:

 (log-edit-mode . ((log-edit-font-lock-gnu-style . t)
                   (log-edit-setup-add-author . t)))

	Jan D.

Re: Fixes: in vc for git?

[Glenn Morris]

"Jan D." wrote:

>> AFAICS, it Just Works by default?
[...]
> Is this a local addition you have?  There is no such thing in my unmodified .dir-locals.el:
>
>  (log-edit-mode . ((log-edit-font-lock-gnu-style . t)
>                    (log-edit-setup-add-author . t)))

Hmph, the bzr and git versions differ!?

http://git.savannah.gnu.org/cgit/emacs.git/tree/.dir-locals.el
http://bzr.savannah.gnu.org/lh/emacs/trunk/annotate/head:/.dir-locals.el

Someone can now have fun figuring out what Hideous Problem this signifies..,

Re: Fixes: in vc for git?

[Glenn Morris]

Stefan Monnier wrote:

> FWIW, I'm not convinced this counts as "it just works".  It looks pretty
> ugly (more ugly than a "(bug#NN)" somewhere in the commit message).
> I'd rather have it moved to the end of the commit message, for example.

Maybe you should have asked for that to be dealt with before allowing
the transition then. But I'm sure someone will quickly respond to your
request now.

Re: Fixes: in vc for git?

[Eli Zaretskii]

> From: Glenn Morris <rgm@gnu.org>
> Date: Sun, 16 Nov 2014 14:29:45 -0500
> Cc: emacs-devel <emacs-devel@gnu.org>
> 
> "Jan D." wrote:
> 
> >> AFAICS, it Just Works by default?
> [...]
> > Is this a local addition you have?  There is no such thing in my unmodified .dir-locals.el:
> >
> >  (log-edit-mode . ((log-edit-font-lock-gnu-style . t)
> >                    (log-edit-setup-add-author . t)))
> 
> Hmph, the bzr and git versions differ!?
> 
> http://git.savannah.gnu.org/cgit/emacs.git/tree/.dir-locals.el
> http://bzr.savannah.gnu.org/lh/emacs/trunk/annotate/head:/.dir-locals.el
> 
> Someone can now have fun figuring out what Hideous Problem this signifies..,

None whatsoever.  Try "git log -n1 .dir-locals.el", and see for
yourself.

Re: Fixes: in vc for git?

[Jan D.]

[-- Attachment #1: Type: text/plain, Size: 717 bytes --]

Paul Eggert removed it at 584fa315db2c041f0e05a9d709c3ee03c7f91be2.

       Jan D.



> 16 nov 2014 kl. 20:29 skrev Glenn Morris <rgm@gnu.org>:
> 
> "Jan D." wrote:
> 
>>> AFAICS, it Just Works by default?
> [...]
>> Is this a local addition you have?  There is no such thing in my unmodified .dir-locals.el:
>> 
>> (log-edit-mode . ((log-edit-font-lock-gnu-style . t)
>>                   (log-edit-setup-add-author . t)))
> 
> Hmph, the bzr and git versions differ!?
> 
> http://git.savannah.gnu.org/cgit/emacs.git/tree/.dir-locals.el
> http://bzr.savannah.gnu.org/lh/emacs/trunk/annotate/head:/.dir-locals.el
> 
> Someone can now have fun figuring out what Hideous Problem this signifies..,

[-- Attachment #2: Type: text/html, Size: 1916 bytes --]

Re: Fixes: in vc for git?

[Glenn Morris]

"Jan D." wrote:

> Paul Eggert removed it at 584fa315db2c041f0e05a9d709c3ee03c7f91be2.

IMO that was a mistake, it should have stayed (just delete the comment).

Re: Fixes: in vc for git?

[Paul Eggert]

Glenn Morris wrote:
> IMO that was a mistake, it should have stayed (just delete the comment).

Sure, that's fine.  I don't use log-edit-mode myself, I was just trying to guess 
how others use it, incorrectly as it turns out.

Re: Fixes: in vc for git?

[Glenn Morris]

Re: http://lists.gnu.org/archive/html/emacs-devel/2014-11/msg01090.html

>> FWIW, I'm not convinced this counts as "it just works".  It looks pretty
>> ugly (more ugly than a "(bug#NN)" somewhere in the commit message).
>> I'd rather have it moved to the end of the commit message, for example.

Any takers for this?
(Making log-edit move "Fixes: xxx" for git to the end of the commit message.)