From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: desktop-buffer-info and set-buffer Date: Sun, 01 Mar 2015 18:12:00 +0200 Message-ID: <83mw3wsnn3.fsf@gnu.org> References: <83oaocspgm.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1425226352 2393 80.91.229.3 (1 Mar 2015 16:12:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 1 Mar 2015 16:12:32 +0000 (UTC) Cc: emacs-devel@gnu.org To: bruce.connor.am@gmail.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 01 17:12:24 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YS6Td-0003Ae-Sx for ged-emacs-devel@m.gmane.org; Sun, 01 Mar 2015 17:12:22 +0100 Original-Received: from localhost ([::1]:53042 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YS6Td-00009P-BJ for ged-emacs-devel@m.gmane.org; Sun, 01 Mar 2015 11:12:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41209) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YS6TZ-00008y-Ut for emacs-devel@gnu.org; Sun, 01 Mar 2015 11:12:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YS6TW-0006v1-NO for emacs-devel@gnu.org; Sun, 01 Mar 2015 11:12:17 -0500 Original-Received: from mtaout24.012.net.il ([80.179.55.180]:45552) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YS6TW-0006up-Fc for emacs-devel@gnu.org; Sun, 01 Mar 2015 11:12:14 -0500 Original-Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0NKJ00800J8WTM00@mtaout24.012.net.il> for emacs-devel@gnu.org; Sun, 01 Mar 2015 18:04:12 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKJ001J6JB0W460@mtaout24.012.net.il>; Sun, 01 Mar 2015 18:04:12 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.180 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:183548 Archived-At: > Date: Sun, 1 Mar 2015 16:06:15 +0000 > From: Artur Malabarba > Cc: emacs-devel > > > Why waste cycles on restoring the buffer, when it will be immediately > > changed to some other buffer? > > Because (by name and purpose) it looks like a function without side effects, so > it's a little surprising that it has. If this is the only issue, documenting it should be enough. > I don't think this would make a noticeable difference in performance, but if > it's necessary for performance reasons I'll just write something on a > docstring. I don't think it's performance-critical, either, but IMO doing unnecessary things is unclean regardless. In any case, this is a minor issue.