From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 5c9304e: Disable some display optimizations when frames need redisplay Date: Sun, 04 Oct 2015 12:53:18 +0300 Message-ID: <83mvvz0xkh.fsf@gnu.org> References: <20150930193450.11644.62040@vcs.savannah.gnu.org> <831tdd75i3.fsf@gnu.org> <83eghd5ff2.fsf@gnu.org> <83vbap3qxb.fsf@gnu.org> <83r3lc4du9.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1443952434 11791 80.91.229.3 (4 Oct 2015 09:53:54 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 4 Oct 2015 09:53:54 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 04 11:53:46 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZifzE-0005HR-ON for ged-emacs-devel@m.gmane.org; Sun, 04 Oct 2015 11:53:44 +0200 Original-Received: from localhost ([::1]:41822 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZifzD-0000Ff-Qr for ged-emacs-devel@m.gmane.org; Sun, 04 Oct 2015 05:53:43 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34824) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zifyx-0000FY-FK for emacs-devel@gnu.org; Sun, 04 Oct 2015 05:53:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zifyu-00044q-8q for emacs-devel@gnu.org; Sun, 04 Oct 2015 05:53:27 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:50157) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zifyu-00044a-0k for emacs-devel@gnu.org; Sun, 04 Oct 2015 05:53:24 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NVO00400WO30O00@a-mtaout20.012.net.il> for emacs-devel@gnu.org; Sun, 04 Oct 2015 12:53:22 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NVO0049KWSX0U00@a-mtaout20.012.net.il>; Sun, 04 Oct 2015 12:53:22 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.166 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:190863 Archived-At: > From: Stefan Monnier > Cc: emacs-devel@gnu.org > Date: Sat, 03 Oct 2015 22:33:06 -0400 > > > Tell you what: if you add commentary that describes the logic of using > > these two variables, the window's and frame's 'redisplay' flags, and > > how all those are used to decide which parts need to be redisplayed, > > and if that commentary makes it clear that the code I added is > > redundant, I will remove the code I added, and see if some alternative > > design would be better. Deal? > > How do you like the patch below? I like it very much, thanks! Please commit. Bonus points for adding something that describes where these variables and the corresponding 'redisplay' flags are checked, because the FOR_EACH_FRAME loop in redisplay_internal doesn't look at the 'redisplay' flags, so a large part of the logic you describe above isn't (easily) visible at that level.