From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 5c9304e: Disable some display optimizations when frames need redisplay
Date: Sun, 04 Oct 2015 12:53:18 +0300 [thread overview]
Message-ID: <83mvvz0xkh.fsf@gnu.org> (raw)
In-Reply-To: <jwvbncfv07e.fsf-monnier+emacsdiffs@gnu.org>
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: emacs-devel@gnu.org
> Date: Sat, 03 Oct 2015 22:33:06 -0400
>
> > Tell you what: if you add commentary that describes the logic of using
> > these two variables, the window's and frame's 'redisplay' flags, and
> > how all those are used to decide which parts need to be redisplayed,
> > and if that commentary makes it clear that the code I added is
> > redundant, I will remove the code I added, and see if some alternative
> > design would be better. Deal?
>
> How do you like the patch below?
I like it very much, thanks! Please commit.
Bonus points for adding something that describes where these variables
and the corresponding 'redisplay' flags are checked, because the
FOR_EACH_FRAME loop in redisplay_internal doesn't look at the
'redisplay' flags, so a large part of the logic you describe above
isn't (easily) visible at that level.
next prev parent reply other threads:[~2015-10-04 9:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150930193450.11644.62040@vcs.savannah.gnu.org>
[not found] ` <E1ZhN9O-00032Q-5G@vcs.savannah.gnu.org>
2015-10-02 12:44 ` [Emacs-diffs] master 5c9304e: Disable some display optimizations when frames need redisplay Stefan Monnier
2015-10-02 13:40 ` Eli Zaretskii
2015-10-02 15:46 ` Stefan Monnier
2015-10-02 17:49 ` Eli Zaretskii
2015-10-02 20:55 ` Stefan Monnier
2015-10-02 21:24 ` Eli Zaretskii
2015-10-03 1:05 ` Stefan Monnier
2015-10-03 7:21 ` Eli Zaretskii
2015-10-04 2:33 ` Stefan Monnier
2015-10-04 9:53 ` Eli Zaretskii [this message]
2015-10-05 15:50 ` Stefan Monnier
2015-10-05 16:57 ` Eli Zaretskii
2015-10-05 22:46 ` Stefan Monnier
2015-10-06 1:19 ` Stefan Monnier
2015-10-06 7:57 ` martin rudalics
2015-10-06 16:15 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83mvvz0xkh.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).