From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Please add comments to isearch.el Date: Sun, 13 Dec 2015 05:38:43 +0200 Message-ID: <83mvtf5870.fsf@gnu.org> References: <83fuzoojcn.fsf@gnu.org> <83poyd8kta.fsf@gnu.org> <20151211121617.GA3351@acm.fritz.box> <83y4d16txk.fsf@gnu.org> <83lh916jpp.fsf@gnu.org> <871tasbnhh.fsf@mail.linkov.net> <83d1uc6sdq.fsf@gnu.org> <874mfntfgq.fsf@mail.linkov.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1449977928 26883 80.91.229.3 (13 Dec 2015 03:38:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 13 Dec 2015 03:38:48 +0000 (UTC) Cc: acm@muc.de, bruce.connor.am@gmail.com, emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Dec 13 04:38:43 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a7xUg-0002Fh-JC for ged-emacs-devel@m.gmane.org; Sun, 13 Dec 2015 04:38:42 +0100 Original-Received: from localhost ([::1]:53833 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7xUf-0004wE-PB for ged-emacs-devel@m.gmane.org; Sat, 12 Dec 2015 22:38:41 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60514) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7xUc-0004vu-RA for emacs-devel@gnu.org; Sat, 12 Dec 2015 22:38:39 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a7xUZ-0007zr-La for emacs-devel@gnu.org; Sat, 12 Dec 2015 22:38:38 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55702) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7xUZ-0007zl-Ii; Sat, 12 Dec 2015 22:38:35 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2247 helo=HOME-C4E4A596F7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1a7xUY-00059u-Kv; Sat, 12 Dec 2015 22:38:35 -0500 In-reply-to: <874mfntfgq.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 13 Dec 2015 01:27:45 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:196198 Archived-At: > From: Juri Linkov > Cc: bruce.connor.am@gmail.com, acm@muc.de, emacs-devel@gnu.org > Date: Sun, 13 Dec 2015 01:27:45 +0200 > > > Hey, I didn't suggest refactoring to begin with. I suggested to add > > commentary to explain how things work there. The example you give is > > just another confirmation of my observation that the code in > > isearch.el has long ago crossed the line of being unmaintainable, and > > I think we should fix that ASAP. > > > > Thanks. > > I completely agree, and as a first step in this direction I propose > to fix the terminology used in isearch that should help to better > understand the code in isearch.el. > > 1. Rename ‘lax’ to ‘lax-boundary’ to distinguish between lax at the word/symbol > boundary and lax-whitespace to avoid confusion, so rename the > arg ‘lax’ to ‘lax-boundary’ in all regexp-producing functions, > isearch--lax-regexp-function-p to > isearch--lax-boundary-regexp-function-p, etc. > > 2. Try to find a better common naming scheme used for the > regexp-producing functions word-search-regexp, isearch-symbol-regexp, > character-fold-to-regexp. > > 3. Use well established terminology that shortens the prefixes > of character-related functions to just char- to use char-fold. > ‘C-h f char TAB’ or ‘C-h v char TAB’ shows the standard > Emacs naming convention. > > 4. Use the upper-case standard name “Unicode” in the documentation. Fine with me (please go ahead), as long as we don't stop there. Because terminology was not my problem when I tried to figure out who does what there. Thanks.