From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH PING] Honor 'SOURCE_DATE_EPOCH' when generating autoloads. Date: Thu, 24 Dec 2015 05:33:16 +0200 Message-ID: <83mvt0o70j.fsf@gnu.org> References: <87k2ph3mgx.fsf@gnu.org> <87io4lnkyz.fsf@gnu.org> <83mvtwoktg.fsf@gnu.org> <878u5gkakj.fsf@gnu.org> <83a8pwoesc.fsf@gnu.org> <87two3475d.fsf@gnu.org> <5665D6B9.4030309@cs.ucla.edu> <5665DAA1.2080208@cs.ucla.edu> <83k2o9t6t1.fsf@gnu.org> <56771D52.2070406@cs.ucla.edu> <83fuytp1au.fsf@gnu.org> <83d1txozu9.fsf@gnu.org> <567B0D81.2000106@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1450927977 19620 80.91.229.3 (24 Dec 2015 03:32:57 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 24 Dec 2015 03:32:57 +0000 (UTC) Cc: p.stephani2@gmail.com, emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 24 04:32:56 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aBwe7-0002uD-MD for ged-emacs-devel@m.gmane.org; Thu, 24 Dec 2015 04:32:55 +0100 Original-Received: from localhost ([::1]:58746 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBwe7-0008LN-01 for ged-emacs-devel@m.gmane.org; Wed, 23 Dec 2015 22:32:55 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36990) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBwdu-0008Ks-MM for emacs-devel@gnu.org; Wed, 23 Dec 2015 22:32:43 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBwdq-0001yU-3d for emacs-devel@gnu.org; Wed, 23 Dec 2015 22:32:42 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41033) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBwdq-0001yL-06; Wed, 23 Dec 2015 22:32:38 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2796 helo=HOME-C4E4A596F7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aBwdp-0002mC-B5; Wed, 23 Dec 2015 22:32:37 -0500 In-reply-to: <567B0D81.2000106@cs.ucla.edu> (message from Paul Eggert on Wed, 23 Dec 2015 13:09:21 -0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:196749 Archived-At: > Cc: emacs-devel@gnu.org > From: Paul Eggert > Date: Wed, 23 Dec 2015 13:09:21 -0800 > > > + (if deterministic-dump "unknown" (system-name)) > > How about changing this to: > > (when (not deterministic-dump) (system-name)) > > and document that the value is nil when unavailable? Some code out there that expects the value to be a string might become broken by such a change, I think. IOW, I think we shouldn't make this an incompatible change.