From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 504696d: Etags: yet another improvement in Ruby tags Date: Fri, 05 Feb 2016 11:14:04 +0200 Message-ID: <83mvrfv7s3.fsf@gnu.org> References: <20160203162536.2954.45438@vcs.savannah.gnu.org> <56B29165.3040404@yandex.ru> <8337t9xhjc.fsf@gnu.org> <56B31B99.6010400@yandex.ru> <83io24wfjl.fsf@gnu.org> <56B4329D.7010101@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1454663675 25068 80.91.229.3 (5 Feb 2016 09:14:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 5 Feb 2016 09:14:35 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 05 10:14:29 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aRcTF-0000lN-CC for ged-emacs-devel@m.gmane.org; Fri, 05 Feb 2016 10:14:29 +0100 Original-Received: from localhost ([::1]:46944 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRcTE-0007ru-PB for ged-emacs-devel@m.gmane.org; Fri, 05 Feb 2016 04:14:28 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53068) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRcT1-0007rk-7H for emacs-devel@gnu.org; Fri, 05 Feb 2016 04:14:16 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aRcSy-0005LR-1e for emacs-devel@gnu.org; Fri, 05 Feb 2016 04:14:15 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44503) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRcSx-0005LN-UB; Fri, 05 Feb 2016 04:14:11 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1304 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aRcSw-0006fx-OJ; Fri, 05 Feb 2016 04:14:11 -0500 In-reply-to: <56B4329D.7010101@yandex.ru> (message from Dmitry Gutov on Fri, 5 Feb 2016 08:26:53 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:199368 Archived-At: > Cc: emacs-devel@gnu.org > From: Dmitry Gutov > Date: Fri, 5 Feb 2016 08:26:53 +0300 > > Would > > alias_method :qux, :tee, :bogus > > trigger the same problem, and use the same fix? No. What comes after the comma must begin with attr_SOMETHING or alias_method. The issue being tested here is that we are not in a state where matches for these are being tried. But if you ever figure out how to do that with a less abnormal syntax, feel free to update the test files. It could also be a good idea to add a Rakefile or a Thorfile to the ruby-src directory (when I tested the change, I just renamed one of the other files). It could be that those present special challenges, and in any case we should test the file-name rules. > If not, please disregard this email. The code works well, and supports > all the main use cases. OK, thanks. I guess we now have the "best etags in the West" (and in the East as well), as far as Ruby support is concerned.