* [PATCH] Call va_end after processing ap
@ 2016-05-02 19:39 Aaron Conole
2016-05-02 20:04 ` Eli Zaretskii
0 siblings, 1 reply; 4+ messages in thread
From: Aaron Conole @ 2016-05-02 19:39 UTC (permalink / raw)
To: emacs-devel
* gnutls.c (boot_error): A recent change added a function to signal an
error or return an error code. That function uses a variadic argument
list to populate an error message string. However, it missed calling
va_end after using the variadic argument list.
---
NOTE: I sent a copy of this from my work email (which isn't
subscribed). Sorry if it is duplicated in the email system, but I didn't
see it land so I'm resending.
src/gnutls.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gnutls.c b/src/gnutls.c
index 57b164a..1089b1a 100644
--- a/src/gnutls.c
+++ b/src/gnutls.c
@@ -1181,6 +1181,7 @@ boot_error (struct Lisp_Process *p, const char *m, ...)
pset_status (p, list2 (Qfailed, vformat_string (m, ap)));
else
verror (m, ap);
+ va_end(ap);
}
Lisp_Object
--
2.5.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Call va_end after processing ap
2016-05-02 19:39 [PATCH] Call va_end after processing ap Aaron Conole
@ 2016-05-02 20:04 ` Eli Zaretskii
0 siblings, 0 replies; 4+ messages in thread
From: Eli Zaretskii @ 2016-05-02 20:04 UTC (permalink / raw)
To: Aaron Conole; +Cc: emacs-devel
> From: Aaron Conole <aconole@bytheb.org>
> Date: Mon, 02 May 2016 15:39:26 -0400
>
> NOTE: I sent a copy of this from my work email (which isn't
> subscribed). Sorry if it is duplicated in the email system
Yes, it's duplicate.
> but I didn't see it land so I'm resending.
Please in the future be patient and allow some time for it to land:
moderators are humans that aren't constantly monitoring the list
administrative interface.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Call va_end after processing ap
@ 2016-05-02 19:39 Aaron Conole
2016-05-02 21:42 ` Lars Ingebrigtsen
0 siblings, 1 reply; 4+ messages in thread
From: Aaron Conole @ 2016-05-02 19:39 UTC (permalink / raw)
To: emacs-devel
* gnutls.c (boot_error): A recent change added a function to signal an
error or return an error code. That function uses a variadic argument
list to populate an error message string. However, it missed calling
va_end after using the variadic argument list.
---
src/gnutls.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gnutls.c b/src/gnutls.c
index 57b164a..1089b1a 100644
--- a/src/gnutls.c
+++ b/src/gnutls.c
@@ -1181,6 +1181,7 @@ boot_error (struct Lisp_Process *p, const char *m, ...)
pset_status (p, list2 (Qfailed, vformat_string (m, ap)));
else
verror (m, ap);
+ va_end(ap);
}
Lisp_Object
--
2.5.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-05-02 21:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-02 19:39 [PATCH] Call va_end after processing ap Aaron Conole
2016-05-02 20:04 ` Eli Zaretskii
-- strict thread matches above, loose matches on Subject: below --
2016-05-02 19:39 Aaron Conole
2016-05-02 21:42 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).