From: Eli Zaretskii <eliz@gnu.org>
To: "Clément Pit--Claudel" <clement.pit@gmail.com>
Cc: acm@muc.de, emacs-devel@gnu.org, schwab@suse.de
Subject: Re: What makes set-window-buffer slow?
Date: Sat, 25 Jun 2016 17:27:17 +0300 [thread overview]
Message-ID: <83mvm9z6m2.fsf@gnu.org> (raw)
In-Reply-To: <576E900F.5070004@gmail.com> (message from Clément Pit--Claudel on Sat, 25 Jun 2016 10:07:11 -0400)
> Cc: acm@muc.de, schwab@suse.de, emacs-devel@gnu.org
> From: Clément Pit--Claudel <clement.pit@gmail.com>
> Date: Sat, 25 Jun 2016 10:07:11 -0400
>
> > Does the WINDOW argument of set-window-buffer name the selected window
> > at the time of the call? If not, set-window-buffer will cause all the
> > other windows to be redisplayed, so arranging for WINDOW to be the
> > selected window might speed up things.
>
> The window was indeed not selected at the time of the call. Would a
> simple with-selected-window around the call do it?
Yes, I think so. Although it'd be better to arrange that to happen
without the need to select the window, if possible.
> If so, could set-window-buffer just do that?
No, of course not. We don't know at this level what is the
programmer's intent.
> Btw, do you think there is any issue with just not calling set-window-buffer if the window already contains that buffer?
Not sure I understand the question: how can there be an issue when NOT
doing something?
> Would it be useful for me to profile the same code on my own
> machine? Maybe comparing the profiles would help.
Could be. But identifying the differences is also useful.
> > Finally, if the user can try a later Emacs, it might help, because
> > some non-trivial redisplay optimizations were done since 24.4.
>
> Ok, I'll keep this in mind; I don't think that will happen for them until Debian updates, though. And in any case, I don't even have this problem on 24.4...
The optimizations might well affect only some system configurations.
next prev parent reply other threads:[~2016-06-25 14:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 15:48 What makes set-window-buffer slow? Clément Pit--Claudel
2016-06-23 16:01 ` Andreas Schwab
2016-06-23 17:45 ` Clément Pit--Claudel
2016-06-23 18:12 ` Alan Mackenzie
2016-06-23 18:30 ` Clément Pit--Claudel
2016-06-23 19:11 ` Eli Zaretskii
2016-06-23 21:23 ` Clément Pit--Claudel
2016-06-24 6:54 ` Eli Zaretskii
2016-06-24 12:33 ` Clément Pit--Claudel
2016-06-24 13:56 ` Eli Zaretskii
2016-06-24 14:19 ` Clément Pit--Claudel
2016-06-24 18:31 ` Clément Pit--Claudel
2016-06-24 19:13 ` Eli Zaretskii
2016-06-24 21:33 ` Clément Pit--Claudel
2016-06-25 7:30 ` Eli Zaretskii
2016-06-25 14:07 ` Clément Pit--Claudel
2016-06-25 14:27 ` Eli Zaretskii [this message]
2016-06-25 14:39 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83mvm9z6m2.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=acm@muc.de \
--cc=clement.pit@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).