From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Preview: portable dumper Date: Fri, 16 Feb 2018 21:57:26 +0200 Message-ID: <83mv08d7x5.fsf@gnu.org> References: <1775923222.898447.1518559575706@mail.libero.it> <83inb0xkfx.fsf@gnu.org> <87o9krdftc.fsf@gmail.com> <83a7wby1x4.fsf@gnu.org> <83r2pnwftj.fsf@gnu.org> <08ac43fb-0b13-8a51-4571-11a21b8ffbdc@dancol.org> <83h8qiw7cd.fsf@gnu.org> <837erddpqb.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1518810958 29969 195.159.176.226 (16 Feb 2018 19:55:58 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 16 Feb 2018 19:55:58 +0000 (UTC) Cc: emacs-devel@gnu.org To: Andy Moreton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 16 20:55:54 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emm6Y-0006Gt-Kv for ged-emacs-devel@m.gmane.org; Fri, 16 Feb 2018 20:55:34 +0100 Original-Received: from localhost ([::1]:55343 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emm8Y-0000VR-P2 for ged-emacs-devel@m.gmane.org; Fri, 16 Feb 2018 14:57:38 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47173) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emm8R-0000UJ-HK for emacs-devel@gnu.org; Fri, 16 Feb 2018 14:57:32 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emm8N-0001fr-Iq for emacs-devel@gnu.org; Fri, 16 Feb 2018 14:57:31 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41457) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emm8N-0001fj-F9; Fri, 16 Feb 2018 14:57:27 -0500 Original-Received: from [176.228.60.248] (port=2617 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1emm8M-0004lb-US; Fri, 16 Feb 2018 14:57:27 -0500 In-reply-to: (message from Andy Moreton on Fri, 16 Feb 2018 17:48:05 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222840 Archived-At: > From: Andy Moreton > Date: Fri, 16 Feb 2018 17:48:05 +0000 > > On Fri 16 Feb 2018, Eli Zaretskii wrote: > > When Angelo reported this, I said I didn't understand how a similar > > code in sysdep.c:emacs_intr_read does compile without a problem, > > although it seems to feed a ptrdiff_t value (which should be 64-bit > > wide in the 64-bit Windows build, just like size_t, except for the > > signedness), similarly to the above. Can you spot why that works? > > The difference is at the top of pdumper.c: > > #ifdef __GNUC__ > # pragma GCC diagnostic error "-Wconversion" > # pragma GCC diagnostic error "-Wshadow" > > Everything else appears to be built without that warning as error. If I > add similar pragmas to sysdep.c then it also emits a dozen or so > conversion warnings as errors. Ah, okay. So I guess we've just uncovered a subtle bug, which affects emacs_intr_read as well, and perhaps other places. Thanks.