build on master broken on macOS? keyboard.c

build on master broken on macOS? keyboard.c

[Filipp Gunbin]

make bootstrap (if it matters, config args were --without-all --without-ns --with-dbus --with-file-notification=no --with-gnutls --with-modules --with-xml2 --with-zlib)

...

keyboard.c:5338:16: warning: implicit declaration of function 'make_lispy_focus_out' is invalid in C99 [-Wimplicit-function-declaration]
        return make_lispy_focus_out (event->frame_or_window);
               ^
keyboard.c:5338:16: warning: incompatible integer to pointer conversion returning 'int' from a function with result type 'Lisp_Object'
      (aka 'union Lisp_X *') [-Wint-conversion]
        return make_lispy_focus_out (event->frame_or_window);
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

...

make[3]: Leaving directory '/Users/fgunbin/src/emacs/admin/unidata'
  CCLD     temacs
ld: warning: option -prebind is obsolete and being ignored
Undefined symbols for architecture x86_64:
  "_make_lispy_focus_out", referenced from:
      _make_lispy_event in keyboard.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [Makefile:608: temacs] Error 1

Filipp

Re: build on master broken on macOS? keyboard.c

[Eli Zaretskii]

> From: Filipp Gunbin <fgunbin@fastmail.fm>
> Date: Fri, 15 Jun 2018 17:06:47 +0300
> 
> make bootstrap (if it matters, config args were --without-all --without-ns --with-dbus --with-file-notification=no --with-gnutls --with-modules --with-xml2 --with-zlib)
> 
> ...
> 
> keyboard.c:5338:16: warning: implicit declaration of function 'make_lispy_focus_out' is invalid in C99 [-Wimplicit-function-declaration]
>         return make_lispy_focus_out (event->frame_or_window);
>                ^
> keyboard.c:5338:16: warning: incompatible integer to pointer conversion returning 'int' from a function with result type 'Lisp_Object'
>       (aka 'union Lisp_X *') [-Wint-conversion]
>         return make_lispy_focus_out (event->frame_or_window);
>                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Thanks, please try again.  I hope I fixed this.

Re: build on master broken on macOS? keyboard.c

[Filipp Gunbin]

On 15/06/2018 17:46 +0300, Eli Zaretskii wrote:

>> From: Filipp Gunbin <fgunbin@fastmail.fm>
>> Date: Fri, 15 Jun 2018 17:06:47 +0300
>>
>> make bootstrap (if it matters, config args were --without-all --without-ns --with-dbus --with-file-notification=no --with-gnutls --with-modules --with-xml2 --with-zlib)
>>
>> ...
>>
>> keyboard.c:5338:16: warning: implicit declaration of function 'make_lispy_focus_out' is invalid in C99 [-Wimplicit-function-declaration]
>>         return make_lispy_focus_out (event->frame_or_window);
>>                ^
>> keyboard.c:5338:16: warning: incompatible integer to pointer conversion returning 'int' from a function with result type 'Lisp_Object'
>>       (aka 'union Lisp_X *') [-Wint-conversion]
>>         return make_lispy_focus_out (event->frame_or_window);
>>                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Thanks, please try again.  I hope I fixed this.

Fixed, thanks for the instant response!

Filipp