From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [RFC]: replace-region-contents
Date: Wed, 06 Feb 2019 19:33:11 +0200
Message-ID: <83mun8styg.fsf@gnu.org>
References: <871s4rqk7u.fsf@gnu.org> <jwvwomitdmm.fsf-monnier+emacs@gnu.org>
	<87o97syvno.fsf@gnu.org> <jwvmunbueps.fsf-monnier+emacs@gnu.org>
	<878syubwv3.fsf@gnu.org> <87y36u9xqt.fsf@gnu.org>
	<83k1ietcox.fsf@gnu.org> <87k1iew3u6.fsf@gnu.org>
	<83va1wsy95.fsf@gnu.org> <87h8dgetp1.fsf@gnu.org>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="159747"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: monnier@IRO.UMontreal.CA, emacs-devel@gnu.org
To: Tassilo Horn <tsdh@gnu.org>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 06 18:35:56 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1grR75-000fOx-Qz
	for ged-emacs-devel@m.gmane.org; Wed, 06 Feb 2019 18:35:55 +0100
Original-Received: from localhost ([127.0.0.1]:54583 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1grR74-0003FN-K1
	for ged-emacs-devel@m.gmane.org; Wed, 06 Feb 2019 12:35:54 -0500
Original-Received: from eggs.gnu.org ([209.51.188.92]:56694)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1grR4l-0002Nh-HX
	for emacs-devel@gnu.org; Wed, 06 Feb 2019 12:33:32 -0500
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45018)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1grR4k-0007SD-E8; Wed, 06 Feb 2019 12:33:30 -0500
Original-Received: from [176.228.60.248] (port=4536 helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1grR4g-0004WR-21; Wed, 06 Feb 2019 12:33:29 -0500
In-reply-to: <87h8dgetp1.fsf@gnu.org> (message from Tassilo Horn on Wed, 06
	Feb 2019 18:02:34 +0100)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:233055
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/233055>

> From: Tassilo Horn <tsdh@gnu.org>
> Cc: monnier@IRO.UMontreal.CA,  emacs-devel@gnu.org
> Date: Wed, 06 Feb 2019 18:02:34 +0100
> 
> The bottleneck is `compareseq' in lib/diffseq.h.

Of course.

> Maybe that could signal if more than some maximum number of
> differences have already been found, and in that case
> `replace-buffer-contents' would fallback to a plain delete and
> insert?

There's the too_expensive member that we currently set to a very large
value; maybe we should set it lower? or provide control on it from
Lisp?

Also, there's the EARLY_ABORT macro that can be defined to cause an
early return when the job is too hard.  Maybe you could try defining
it to something appropriate?