From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Towards a cleaner build: rmailmm
Date: Fri, 14 Jun 2019 10:23:45 +0300
Message-ID: <83muiky6im.fsf@gnu.org>
References: <m3r28xrfl9.fsf@gnus.org> <83zhn6zkgf.fsf@gnu.org>
 <m3lfyqobq7.fsf@gnus.org>
 <CAM-tV--MF1oCYQ+BFX=PW27ZMYEPzxajkGb0oo7msVidHD-Ceg@mail.gmail.com>
 <m3d0k1o6gl.fsf@gnus.org> <jwvimtttg8t.fsf-monnier+emacs@gnu.org>
 <m3ftoi3m5o.fsf@gnus.org> <m3blz63j41.fsf@gnus.org>
 <CAM-tV-85nAR_vHoXhmZfuu1ndfK-6FVopzKMbwtfDmm7gkU7Kw@mail.gmail.com>
 <m336ki3ghd.fsf@gnus.org> <jwvimteipi7.fsf-monnier+emacs@gnu.org>
 <m3v9xezi75.fsf@gnus.org> <m3r282zfjx.fsf@gnus.org>
 <83a7eo9nsh.fsf@gnu.org> <m3k1dqzyul.fsf@gnus.org>
 <m336kezrno.fsf@gnus.org> <jwvzhmmsca1.fsf-monnier+emacs@gnu.org>
 <m3sgsel567.fsf@gnus.org> <m3k1dpk7y7.fsf@gnus.org>
 <m3ftodk7ps.fsf@gnus.org> <m34l4tk63m.fsf_-_@gnus.org>
 <jwvk1dpp23x.fsf-monnier+emacs@gnu.org>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="178087"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: emacs-devel@gnu.org
To: Stefan Monnier <monnier@iro.umontreal.ca>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 14 09:25:09 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hbga7-000jyw-69
	for ged-emacs-devel@m.gmane.org; Fri, 14 Jun 2019 09:25:03 +0200
Original-Received: from localhost ([::1]:48950 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.86_2)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hbga5-0006bF-P3
	for ged-emacs-devel@m.gmane.org; Fri, 14 Jun 2019 03:25:01 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38928)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <eliz@gnu.org>) id 1hbgYy-0006b6-CV
 for emacs-devel@gnu.org; Fri, 14 Jun 2019 03:23:53 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49664)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
 id 1hbgYx-0003op-6P; Fri, 14 Jun 2019 03:23:51 -0400
Original-Received: from [176.228.60.248] (port=3152 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1hbgYq-0000N2-OY; Fri, 14 Jun 2019 03:23:47 -0400
In-reply-to: <jwvk1dpp23x.fsf-monnier+emacs@gnu.org> (message from Stefan
 Monnier on Thu, 13 Jun 2019 18:15:31 -0400)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:237576
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/237576>

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Thu, 13 Jun 2019 18:15:31 -0400
> 
> > But...  wouldn't string-to-unibyte be the right thing here anyway?
> 
> I'd tend to agree.  string-as-unibyte ends up basically encoding with
> `utf-8-emacs-unix` coding-system which seems like an odd choice here.

I think we should simply remove that call and use the result of
buffer-string directly.  The buffer whose text we are receiving from
buffer-string is a unibyte buffer, so the string will also be unibyte.
I just tried this on my recent mail and didn't see any problems.

> > I'm not an rmail user, so I can't test this.
> 
> Neither am I.

I am.