From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master fe3676f: (Finsert_file_contents): Keep buffer consistent in non-local exit Date: Wed, 03 Jul 2019 20:10:40 +0300 Message-ID: <83muhvavsf.fsf@gnu.org> References: <83d0ird3ka.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="63527"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 03 19:12:49 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hiioH-000GIV-Gr for ged-emacs-devel@m.gmane.org; Wed, 03 Jul 2019 19:12:45 +0200 Original-Received: from localhost ([::1]:37848 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiioG-0007NG-HM for ged-emacs-devel@m.gmane.org; Wed, 03 Jul 2019 13:12:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45067) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiimU-0005zV-6x for emacs-devel@gnu.org; Wed, 03 Jul 2019 13:10:55 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44718) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hiimT-0002aI-3j; Wed, 03 Jul 2019 13:10:53 -0400 Original-Received: from [176.228.60.248] (port=4771 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hiimS-00013O-DR; Wed, 03 Jul 2019 13:10:52 -0400 In-reply-to: (message from Stefan Monnier on Wed, 03 Jul 2019 12:43:10 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238335 Archived-At: > From: Stefan Monnier > Cc: emacs-devel@gnu.org > Date: Wed, 03 Jul 2019 12:43:10 -0400 > > 1- do as I do now (i.e. stay in unibyte even if the buffer was > originally in multibyte). > 2- erase the text we loaded (i.e. all the text, since the buffer > started as empty) and revert the buffer to its original multibyteness > state. > 3- decode the text with some "default" coding system. Note that the > behavior (1) basically corresponds to a `no-conversion` coding system > (since such a coding system also forces the buffer to unibyte). > 4- keep the old "arbitrary bytes in a multibyte buffer" bug. > > I think only (4) is clearly inferior and neither of the other is clearly > superior, so I went with the easier choice, especially since it's > expected to be a very rare corner case occurrence anyway (after all, we > lived with (4) for many years). I think we should do 2. > W.r.t the undo-list, I don't have a good reason for this choice, it was > just easier. Since the buffer started as empty, there's a good chance > that the undo list had no interesting info anyway, so I felt like this > is even less important. I think we should restore undo-list, because (a) it isn't hard, and (b) someone at some point will complain if we don't. > > . fail to reset the markers and overlays to their previous state > > . fail to reset intervals > > These only need to be "reset" in the normal code path because we remove > the text from the buffer (to put it into the gap and then decode it), > but since in this case we don't remove the text, there's no need to do > that (and remember that the buffer was empty to start with so there's > not much "previous state" to restore in this respect). I don't think I understand this. Are you saying that empty buffers cannot have markers and overlays?