unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: 조성빈 <pcr910303@icloud.com>
Cc: alan@idiocy.org, emacs-devel@gnu.org
Subject: Re: [PATCH v5] Enable xwidgets on macOS
Date: Sat, 03 Aug 2019 13:03:27 +0300	[thread overview]
Message-ID: <83mugqefbk.fsf@gnu.org> (raw)
In-Reply-To: <239138BF-21FE-4A24-977E-CD964A233D93@icloud.com> (message from 조성빈 on Tue, 30 Jul 2019 02:08:40 +0900)

> From: 조성빈 <pcr910303@icloud.com>
> Date: Tue, 30 Jul 2019 02:08:40 +0900
> Cc: alan@idiocy.org,
>  emacs-devel@gnu.org
> 
> >>>> +(defun xwidget-webkit-save-as-file (url mime-type file-name)
> >>>> +  "For XWIDGET webkit, save URL of MIME-TYPE to location specified by user.
> >>>> +FILE-NAME combined with `xwidget-webkit-download-dir' is the default file name
> >>>> +of the prompt when reading.  When the file name the user specified is a
> >>>> +directory, URL is saved at the specified directory as FILE-NAME."
> >>> 
> >>> The last sentence is unclear: what will be the directory where the URL
> >>> will be saved, and what will be the name of the saved file in that
> >>> directory?
> >> 
> >> Well, it was meaning that the URL will be saved at the directory the user specified in the prompt with the name FILE-NAME.
> >> 
> >> I’m not sure how I should reword it due to my  poor English skills; can you give me some suggestions? 
> > 
> > If you show me an example of using this command, and the results -- in
> > what directory and under what base name will the URL be saved -- then
> > I will be able to suggest a better wording.
> 
> Sorry for the delay; I was busy for a few days that I couldn't open my mailbox.
> 
> Well, while I was trying to give examples, I think I wrote a clearer version of the docstring:
> "Save URL of MIME-TYPE as file specified by user.
> When the user specifies a directory, URL is saved with the name FILE-NAME in the
>  specified directory.  The default file name when reading is FILE-NAME expanded
>  with `xwidget-webkit-download-dir'."
> 
> May I ask if this is more clear than before?

I don't think I understand what happens well enough yet.  The command
asks for FILE-NAME, right?  So when the FILE-NAME provided by the user
is actually a directory, the URL will be saved in the directory named
FILE-NAME, but under what basename?



  reply	other threads:[~2019-08-03 10:03 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-18 19:23 [PATCH v4] Enable xwidgets on macOS Sungbin Jo
2019-07-19  4:16 ` [PATCH v5] " Sungbin Jo
2019-07-19 19:17   ` Alan Third
2019-07-19 19:25     ` Savannah down (was: [PATCH v5] Enable xwidgets on macOS) Paul Eggert
2019-07-20  8:21   ` [PATCH v5] Enable xwidgets on macOS Eli Zaretskii
2019-07-23 18:36     ` 조성빈
2019-07-25 18:51       ` 조성빈
2019-07-26  5:55         ` Eli Zaretskii
2019-07-27  2:48           ` Richard Stallman
2019-07-27  8:38             ` Eli Zaretskii
2019-07-27 10:41         ` Eli Zaretskii
2019-07-27 12:35           ` 조성빈
2019-07-27 13:03             ` Eli Zaretskii
2019-07-29 17:08               ` 조성빈
2019-08-03 10:03                 ` Eli Zaretskii [this message]
2019-08-03 10:52                   ` 조성빈
2019-07-29 20:26         ` Alan Third
2019-07-29 21:02           ` Stefan Monnier
2019-07-30 15:35             ` 조성빈
2019-07-30 19:25               ` Stefan Monnier
2019-07-31 15:52                 ` 조성빈
2019-07-30 15:33           ` 조성빈
2019-07-30 19:12             ` Juri Linkov
2019-07-31 15:55               ` 조성빈
2019-07-31 19:56             ` Alan Third
2019-08-01  2:35               ` Eli Zaretskii
2019-08-01  4:00                 ` 조성빈
2019-08-02  0:47                   ` Richard Stallman
2019-08-02  7:02                     ` Eli Zaretskii
2019-08-03  2:23                       ` Richard Stallman
2019-08-03  6:58                         ` Eli Zaretskii
2019-08-01 21:39                 ` macOS/GCC support policy (was: [PATCH v5] Enable xwidgets on macOS) Alan Third
2019-08-02  2:22                   ` Noam Postavsky
2019-08-02  6:56                   ` macOS/GCC support policy Eli Zaretskii
2019-08-02 10:08                     ` Philipp Stephani
2019-08-02 11:51                       ` Eli Zaretskii
2019-08-02 14:55                         ` Philipp Stephani
2019-08-02 14:59                           ` Philipp Stephani
2019-08-02 15:06                             ` Philipp Stephani
2019-08-02 15:05                           ` Eli Zaretskii
2019-08-03 11:02                             ` Alan Third
2019-08-03 11:10                               ` Eli Zaretskii
2019-08-03 11:18                                 ` Alan Third
2019-08-03 11:43                                   ` Eli Zaretskii
2019-08-04  2:56                                   ` Richard Stallman
2019-08-10  9:56                                     ` 조성빈
2019-08-18 15:43                                       ` Alan Third
2019-08-18 16:40                                         ` Eli Zaretskii
2019-08-18 23:42                                         ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83mugqefbk.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=alan@idiocy.org \
    --cc=emacs-devel@gnu.org \
    --cc=pcr910303@icloud.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).